openstack
/
kolla
Code Issues Proposed changes

Fix argument to handle_permissions 

Fix the format of argument passed to handle_permissions function, so
that handle_permissions can handle permissions and ownerships of
config_files.

Change-Id: Ic07975a16973df22cdaa6685fc326620812f8f65
Closes-Bug: #1701876
This commit is contained in:
Chulmin Kang 2017-07-02 16:09:30 +09:00
parent f26b1ba0b3
commit ea3d140cab
2 changed files with 7 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
docker/base/set_configs.py
View File

@ -121,8 +121,9 @@ class ConfigFile(object):
os.chown(dest, stat.st_uid, stat.st_gid)
def _set_properties_from_conf(self, path):
handle_permissions({'owner': self.owner, 'path': path,
'perm': self.perm})
config = {'permissions':
[{'owner': self.owner, 'path': path, 'perm': self.perm}]}
handle_permissions(config)
def copy(self):

7
tests/test_set_config.py
View File

@ -143,9 +143,10 @@ class ConfigFileTest(base.BaseTestCase):
config_file = copy.deepcopy(FAKE_CONFIG_FILE)
config_file._set_properties_from_conf(config_file.dest)
mock_handle_permissions.assert_called_with({'owner': 'user1',
'path': config_file.dest,
'perm': '0644'})
mock_handle_permissions.assert_called_with({'permissions':
[{'owner': 'user1',
'path': config_file.dest,
'perm': '0644'}]})
@mock.patch('glob.glob', return_value=[])
def test_copy_no_source_not_optional(self,