openstack/kolla
Code Issues Proposed changes

Py3 and py2 implementation for kolla/image module

Browse Source 
This commit addresses the changes in kolla/image
directory for better openstack python coding style.
unittest also added for corresponding changes.

Reference:- https://wiki.openstack.org/wiki/Python3

Change-Id: I8be60ebd214ac8ab400cc633f8e6005fb8760c24
Partially-Implements: blueprint support-python-35
This commit is contained in:
Surya Prakash Singh 2016-12-26 09:59:56 +05:30
parent 12bea3f9f6
commit efa628d015
2 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
kolla/image/build.py
View File

@ -497,7 +497,8 @@ class KollaWorker(object):
self.install_type = conf.install_type
self.tag = conf.tag
self.images = list()
rpm_setup_config = filter(None, conf.rpm_setup_config)
rpm_setup_config = ([repo_file for repo_file in
conf.rpm_setup_config if repo_file is not None])
self.rpm_setup = self.build_rpm_setup(rpm_setup_config)
rh_base = ['centos', 'oraclelinux', 'rhel']

5
kolla/tests/test_build.py
View File

@ -230,6 +230,11 @@ class KollaWorkerTest(base.TestCase):
self.assertEqual(2, len(self._get_matched_images(kolla.images)))
def test_build_rpm_setup(self):
"""checking the length of list of docker commands"""
kolla = build.KollaWorker(self.conf)
self.assertEqual(2, len(kolla.rpm_setup))
def test_pre_defined_exist_profile(self):
# default profile include the fake image: image-base
self.conf.set_override('profile', ['default'])