We don't need tox nor tell our users to use it when doing kolla builds.
Tox is going away from base infra images (it is already gone from
Co-authored-by: Marcin Juszkiewicz <firstname.lastname@example.org>
The repo is Python 3 now, so update hacking to version 3.0 which
supports Python 3.
Fix problems found by updated hacking version.
Update local hacking checks for new flake8.
Remove hacking and friends from lower-constraints, they are not
needed in installations.
Adds build and publishing jobs for CentOS 8 images:
The 'base' image has been added to the list of unbuildable images for
CentOS 8 (now separate from the list for CentOS 7). This means that no
images will be built - the jobs should essentially be a 'noop'.
Partially-Implements: blueprint centos-rhel-8
Sphinx 1.8 introduced  the '--keep-going' argument which, as its name
suggests, keeps the build running when it encounters non-fatal errors.
This is exceptionally useful in avoiding a continuous edit-build loop
when undertaking large doc reworks where multiple errors may be
If stestr failed, then no node info was logged.
Logging node info is now handled in pre and post stages of Zuul.
Additionally Zuul v3 migration recommendations were applied
and some unused code removed improving general readability.
Signed-off-by: Radosław Piliszek <email@example.com>
According to Openstack summit session ,
stestr is maintained project to which all Openstack projects should migrate.
Let's switch to stestr as other projects have already moved to it.
We want to default to running all tox environments under python 3, so
set the basepython value in each environment.
We do not want to specify a minor version number, because we do not
want to have to update the file every time we upgrade python.
We do not want to set the override once in testenv, because that
breaks the more specific versions used in default environments like
py35 and py36.
Signed-off-by: Doug Hellmann <firstname.lastname@example.org>
Bandit was not running in all directories
due missing -r parameter.
Also, this change fix bandit errors.
* Add nosec to subprocess module
* Change /tmp/releases to .releases
* Change /tmp/ to tmp/, tmp/ is not checked
and in unittest is not an issue, simpler that mocking tempfile
and make more complex tests.
Some of the available checks are disabled by default, like:
[H106] Don’t put vim configuration in source files
[H203] Use assertIs(Not)None to check for None
At the moment, deploy_aio.sh is called with sudo which results
in the environment being wiped. This means that all Zuul
environment variables are removed and therefore when zuul-cloner
runs to checkout the branch of kolla-ansible, it will always
fallback to master as ZUUL_BRANCH is unset.
This patch removes the global usage of sudo in the tox.ini file
as there is existing usage of sudo in the bash script itself. This
will mean that we will only escalate privileges when needed rather
for the whole script and the environment variables should be passed
on properly resulting in the matching release of kolla-ansible being
This patch add the coverage tool package to test-requirements.txt
which was missing, while kolla support coverage. In addtion to this
tox.ini coverage command is modified to reflect the coverage report
in standard output whenever "tox -e cover" command run for better
representation of coverage report.
Partially-Implements: blueprint coverage-increment-for-kolla