kolla/fix-config-check-c973c462761a4fa9.yaml at 0eddd35da52c3e74a4c372796bf65247b261f7f0 - kolla - OpenDev: Free Software Needs Free Tools

openstack/kolla

Mark Goddard c5320eb223 Fix kolla_set_configs --check with a directory

There are several issues with kolla_set_configs --check:

1. We calculate the destination path incorrectly when comparing a file
   in a directory, due to passing arguments to os.path.relpath in the
   wrong order
2. For directories that have not changed, we also attempt to compare
   them as files, which fails when they are open()ed.
3. If the config JSON does not have a config_files key, it fails with a
   KeyError.

The first two issues affect the fluentd container, which specifies
directories as the source, without using a glob. The third affects OVN
containers.

This patch fixes these issues.

Closes-Bug: #1890567

Change-Id: I8921befe51da4282121443849177a7ca5ebe8822

2020-08-28 15:01:25 +00:00

7 lines

186 B

YAML

Raw Blame History

 ---
 fixes:
   - |
     Fixes an issue with the ``kolla_set_configs --check`` command when the
     source is a directory. `LP#1890567
     <https://bugs.launchpad.net/kolla/+bug/1890567>`__