dfddcce3a5
There are currently a few corner cases with the --skip-existing and --skip-parents flags. Examples: 1. kolla-build --type source --skip-parents monasca-grafana This does not try to build the monasca-grafana image. This appears to be an issue when the image is a grandchild. 2. kolla-build --type source --skip-parents This will build all images. Expect it to skip parents. 3. kolla-build --type source --skip-existing This will build all images. Expect it to skip existing images. The filter_images method does quite a lot, including handling whether images are buildable, regex/profile matching, and which images to skip. The matching and skipping parts are done in a single pass, which can lead to some weird effects due to dependencies between the images and their statuses. Also, skipping is only currently applied when there is a regex/profile filter. This change splits out the matching and skipping into two separate passes. In the first pass, we mark all buildable images that match the filter as matched. In the second, we iterate over matched images, applying the skip existing and skip parents rules. Change-Id: I2f895aea0cc59d808129e9fc636af0890196af33 Closes-Bug: #1867614 Related-Bug: #1810979
12 lines
430 B
YAML
12 lines
430 B
YAML
---
|
|
fixes:
|
|
- |
|
|
Fixes an issue with the ``--skip-existing`` and ``--skip-parents`` flags
|
|
which could cause images to not build. `LP#1867614
|
|
<https://launchpad.net/bugs/1867614>`__.
|
|
upgrade:
|
|
- |
|
|
Changes the behaviour of the ``--skip-existing`` and ``--skip-parents``
|
|
flags. Previously these were not applied if no regular expression or
|
|
profile argument was provided to ``kolla-build``, but now they are.
|