Update patch set 12
Patch Set 12: Code-Review+2 (2 comments) Looks good. Patch-set: 12 Reviewer: Gerrit User 13692 <13692@4a232e18-c5a9-48ee-94c0-e04e7cca6543> Label: Code-Review=+2
This commit is contained in:
parent
54c8925046
commit
10e93505f9
|
@ -0,0 +1,44 @@
|
|||
{
|
||||
"comments": [
|
||||
{
|
||||
"key": {
|
||||
"uuid": "1ccdc44c_b22974bb",
|
||||
"filename": "devstack/lib/kuryr_kubernetes",
|
||||
"patchSetId": 12
|
||||
},
|
||||
"lineNbr": 211,
|
||||
"author": {
|
||||
"id": 13692
|
||||
},
|
||||
"writtenOn": "2021-03-03T06:15:15Z",
|
||||
"side": 1,
|
||||
"message": "ultranit: indentation is kind of weird. Entire file have 4 spaces indentation, yet here is 2.",
|
||||
"range": {
|
||||
"startLine": 211,
|
||||
"startChar": 4,
|
||||
"endLine": 211,
|
||||
"endChar": 6
|
||||
},
|
||||
"revId": "daddd7a77b9fa4fcb2a6e0397fe63cdd1a94aec7",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": true
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "6229b5b3_e9b172b7",
|
||||
"filename": "devstack/plugin.sh",
|
||||
"patchSetId": 12
|
||||
},
|
||||
"lineNbr": 243,
|
||||
"author": {
|
||||
"id": 13692
|
||||
},
|
||||
"writtenOn": "2021-03-03T06:15:15Z",
|
||||
"side": 1,
|
||||
"message": "Iterating on subnets array doesn\u0027t hurt, even when we have only one element, no?",
|
||||
"revId": "daddd7a77b9fa4fcb2a6e0397fe63cdd1a94aec7",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": true
|
||||
}
|
||||
]
|
||||
}
|
Loading…
Reference in New Issue