Update patch set 10

Patch Set 10: Code-Review-1 (5 comments) Patch-set: 10 Reviewer: Gerrit User 23567 <23567@4a232e18-c5a9-48ee-94c0-e04e7cca6543> Label: Code-Review=-1
2021-07-08 06:41:14 +00:00 · 2021-07-08 06:41:14 +00:00 · 16509c7b36
parent 94b3df4e43
commit 16509c7b36
1 changed files with 119 additions and 0 deletions
--- a/119
+++ b/119
@ -0,0 +1,119 @@
+{
+  "comments": [
+    {
+      "key": {
+        "uuid": "851bd213_4673a647",
+        "filename": "kuryr_kubernetes/controller/drivers/utils.py",
+        "patchSetId": 10
+      },
+      "lineNbr": 362,
+      "author": {
+        "id": 23567
+      },
+      "writtenOn": "2021-07-08T06:41:14Z",
+      "side": 1,
+      "message": "this still needs to be \"merged\" with the previous function to avoid code duplication",
+      "range": {
+        "startLine": 344,
+        "startChar": 0,
+        "endLine": 362,
+        "endChar": 32
+      },
+      "revId": "062ade6efd134efe18f44786c0a78e011b8d19bc",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": true
+    },
+    {
+      "key": {
+        "uuid": "96a6ad66_c27f6b5c",
+        "filename": "kuryr_kubernetes/controller/handlers/loadbalancer.py",
+        "patchSetId": 10
+      },
+      "lineNbr": 139,
+      "author": {
+        "id": 23567
+      },
+      "writtenOn": "2021-07-08T06:41:14Z",
+      "side": 1,
+      "message": "crd_loadbalancer_ids?",
+      "range": {
+        "startLine": 139,
+        "startChar": 8,
+        "endLine": 139,
+        "endChar": 29
+      },
+      "revId": "062ade6efd134efe18f44786c0a78e011b8d19bc",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": true
+    },
+    {
+      "key": {
+        "uuid": "c1f96072_eb128c7d",
+        "filename": "kuryr_kubernetes/controller/handlers/loadbalancer.py",
+        "patchSetId": 10
+      },
+      "lineNbr": 142,
+      "author": {
+        "id": 23567
+      },
+      "writtenOn": "2021-07-08T06:41:14Z",
+      "side": 1,
+      "message": "seems you are not using the name, so it can be removed",
+      "range": {
+        "startLine": 141,
+        "startChar": 32,
+        "endLine": 142,
+        "endChar": 77
+      },
+      "revId": "062ade6efd134efe18f44786c0a78e011b8d19bc",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": true
+    },
+    {
+      "key": {
+        "uuid": "8f4eb164_17e86ee0",
+        "filename": "kuryr_kubernetes/controller/handlers/loadbalancer.py",
+        "patchSetId": 10
+      },
+      "lineNbr": 158,
+      "author": {
+        "id": 23567
+      },
+      "writtenOn": "2021-07-08T06:41:14Z",
+      "side": 1,
+      "message": "this should have a return to not process the rest",
+      "range": {
+        "startLine": 157,
+        "startChar": 0,
+        "endLine": 158,
+        "endChar": 63
+      },
+      "revId": "062ade6efd134efe18f44786c0a78e011b8d19bc",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": true
+    },
+    {
+      "key": {
+        "uuid": "7722aca0_4b08898b",
+        "filename": "kuryr_kubernetes/controller/handlers/loadbalancer.py",
+        "patchSetId": 10
+      },
+      "lineNbr": 168,
+      "author": {
+        "id": 23567
+      },
+      "writtenOn": "2021-07-08T06:41:14Z",
+      "side": 1,
+      "message": "what if there is other type of exception? I think at least K8sClientException should be handled too",
+      "range": {
+        "startLine": 168,
+        "startChar": 12,
+        "endLine": 168,
+        "endChar": 45
+      },
+      "revId": "062ade6efd134efe18f44786c0a78e011b8d19bc",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": true
+    }
+  ]
+}