openstack
/
kuryr-kubernetes
Code Issues Proposed changes

Update patch set 3 

Patch Set 3:

(1 comment)

Patch-set: 3
Attention: {"person_ident":"Gerrit User 11600 \u003c11600@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_31857\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 31857 \u003c31857@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_31857\u003e replied on the change"}
This commit is contained in:
Gerrit User 31857 2024-03-05 10:09:54 +00:00 committed by Gerrit Code Review
parent 837c31c58e
commit 17b8d886d1
1 changed files with 18 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
7acb2be008a93dd8cf1e19f79a31a43452aac806
View File

@ -34,6 +34,24 @@
"parentUuid": "d31ba5a5_012d5dd9",
"revId": "7acb2be008a93dd8cf1e19f79a31a43452aac806",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "5672b8c9_7e5dfd0f",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 3
},
"lineNbr": 0,
"author": {
"id": 31857
},
"writtenOn": "2024-03-05T10:09:54Z",
"side": 1,
"message": "Thanks for your comments.\n\nFor this patch, is it better to drop the docker gate,\n\n\u003e * https://opendev.org/openstack/kuryr-kubernetes/src/branch/master/.zuul.d/project.yaml#L20\n\u003e * https://opendev.org/openstack/kuryr-kubernetes/src/branch/master/.zuul.d/tempest-jobs.yaml#L180-L188\n\nor just change `voting` to false (and drop the docker gate by the another patch)?\n\n\u003e * https://opendev.org/openstack/kuryr-kubernetes/src/branch/master/.zuul.d/tempest-jobs.yaml#L187",
"parentUuid": "dd4480c4_a10b816f",
"revId": "7acb2be008a93dd8cf1e19f79a31a43452aac806",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}