Update patch set 25
Patch Set 25: Code-Review-1 (2 comments) Patch-set: 25 Reviewer: Gerrit User 27032 <27032@4a232e18-c5a9-48ee-94c0-e04e7cca6543> Label: Code-Review=-1
This commit is contained in:
parent
c33d031d6f
commit
349d229eac
|
@ -0,0 +1,50 @@
|
|||
{
|
||||
"comments": [
|
||||
{
|
||||
"key": {
|
||||
"uuid": "271caa8f_8ca5a14c",
|
||||
"filename": "kuryr_kubernetes/tests/unit/controller/handlers/test_loadbalancer.py",
|
||||
"patchSetId": 25
|
||||
},
|
||||
"lineNbr": 188,
|
||||
"author": {
|
||||
"id": 27032
|
||||
},
|
||||
"writtenOn": "2021-07-23T08:38:26Z",
|
||||
"side": 1,
|
||||
"message": "Should these two loadbalancers have different ID? it\u0027s not possible for them to have same ID.",
|
||||
"range": {
|
||||
"startLine": 188,
|
||||
"startChar": 28,
|
||||
"endLine": 188,
|
||||
"endChar": 39
|
||||
},
|
||||
"revId": "e790508842493d7d32f13c94ddda76d973f2f619",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": true
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "d60efc47_aa17b9df",
|
||||
"filename": "kuryr_kubernetes/tests/unit/controller/handlers/test_loadbalancer.py",
|
||||
"patchSetId": 25
|
||||
},
|
||||
"lineNbr": 678,
|
||||
"author": {
|
||||
"id": 27032
|
||||
},
|
||||
"writtenOn": "2021-07-23T08:38:26Z",
|
||||
"side": 1,
|
||||
"message": "maybe you can also assert that load_balancers is called as you\u0027re mocking the return value at line 670. (same applies for the other test case)",
|
||||
"range": {
|
||||
"startLine": 678,
|
||||
"startChar": 35,
|
||||
"endLine": 678,
|
||||
"endChar": 53
|
||||
},
|
||||
"revId": "e790508842493d7d32f13c94ddda76d973f2f619",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": true
|
||||
}
|
||||
]
|
||||
}
|
Loading…
Reference in New Issue