openstack
/
kuryr-kubernetes
Code Issues Proposed changes

Update patch set 5 

Patch Set 5: Code-Review-1

(1 comment)

Please check the comments at patch set 4, I guess they were missed. Also, here is one more suggestion:

Patch-set: 5
Reviewer: Gerrit User 27032 <27032@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=-1
This commit is contained in:
Gerrit User 27032 2021-07-02 10:00:58 +00:00 committed by Gerrit Code Review
parent 175755813b
commit 7c5eea8047
1 changed files with 17 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
c943b973e562603cb15893f62ffb84bc76a79a61
View File

@ -92,6 +92,23 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": true
},
{
"key": {
"uuid": "1fd61089_86500bc2",
"filename": "kuryr_kubernetes/controller/handlers/loadbalancer.py",
"patchSetId": 5
},
"lineNbr": 154,
"author": {
"id": 27032
},
"writtenOn": "2021-07-02T10:00:58Z",
"side": 1,
"message": "This loop can be avoided if you use the loop at line 149.",
"revId": "c943b973e562603cb15893f62ffb84bc76a79a61",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": true
},
{
"key": {
"uuid": "147d1b27_6e63f583",