openstack
/
kuryr-kubernetes
Code Issues Proposed changes

Update patch set 12 

Patch Set 12: Code-Review-1

(5 comments)

Patch-set: 12
Reviewer: Gerrit User 27032 <27032@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=-1
This commit is contained in:
Gerrit User 27032 2021-07-12 08:59:04 +00:00 committed by Gerrit Code Review
parent d16420bdf4
commit 7fd486e6a4
1 changed files with 105 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

105
7ecb3e2ba2eabd65bcd564d5a438de97b20c9b3a
View File

@ -53,6 +53,29 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": true
},
{
"key": {
"uuid": "9c83ac6f_093c74e5",
"filename": "kuryr_kubernetes/controller/drivers/utils.py",
"patchSetId": 12
},
"lineNbr": 349,
"author": {
"id": 27032
},
"writtenOn": "2021-07-12T08:59:04Z",
"side": 1,
"message": "Why does the resource need to be reassigned?\nBetter to directly change the name of resource parameter to resource_path instead.",
"range": {
"startLine": 349,
"startChar": 8,
"endLine": 349,
"endChar": 21
},
"revId": "7ecb3e2ba2eabd65bcd564d5a438de97b20c9b3a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": true
},
{
"key": {
"uuid": "c0147a1a_b2925052",
@ -76,6 +99,40 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": true
},
{
"key": {
"uuid": "b4a5687a_66c95b05",
"filename": "kuryr_kubernetes/controller/drivers/utils.py",
"patchSetId": 12
},
"lineNbr": 358,
"author": {
"id": 27032
},
"writtenOn": "2021-07-12T08:59:04Z",
"side": 1,
"message": "might be safer to define klbs \u003d {} before the try/except block or move this return to line 351",
"revId": "7ecb3e2ba2eabd65bcd564d5a438de97b20c9b3a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": true
},
{
"key": {
"uuid": "4aec6b0d_768698b2",
"filename": "kuryr_kubernetes/controller/handlers/loadbalancer.py",
"patchSetId": 12
},
"lineNbr": 137,
"author": {
"id": 27032
},
"writtenOn": "2021-07-12T08:59:04Z",
"side": 1,
"message": "This same function is called at line 172 also for KuryrLoadBalancers. They can be moved to outside (line 122) and pass the return as parameter of the trigger_* functions, avoiding to call k8s API twice.",
"revId": "7ecb3e2ba2eabd65bcd564d5a438de97b20c9b3a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": true
},
{
"key": {
"uuid": "69298ff3_c844a1d9",
@ -99,6 +156,30 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": true
},
{
"key": {
"uuid": "8b881d9d_a4667bfc",
"filename": "kuryr_kubernetes/controller/handlers/loadbalancer.py",
"patchSetId": 12
},
"lineNbr": 178,
"author": {
"id": 27032
},
"writtenOn": "2021-07-12T08:59:04Z",
"side": 1,
"message": "+1",
"parentUuid": "69298ff3_c844a1d9",
"range": {
"startLine": 178,
"startChar": 24,
"endLine": 178,
"endChar": 76
},
"revId": "7ecb3e2ba2eabd65bcd564d5a438de97b20c9b3a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": true
},
{
"key": {
"uuid": "a91889b5_2eb07743",
@ -168,6 +249,30 @@
"revId": "7ecb3e2ba2eabd65bcd564d5a438de97b20c9b3a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": true
},
{
"key": {
"uuid": "70c725a2_e77ac18d",
"filename": "kuryr_kubernetes/controller/handlers/loadbalancer.py",
"patchSetId": 12
},
"lineNbr": 222,
"author": {
"id": 27032
},
"writtenOn": "2021-07-12T08:59:04Z",
"side": 1,
"message": "+1 no need to have this extra function",
"parentUuid": "ccdddc5b_d94ee82e",
"range": {
"startLine": 210,
"startChar": 1,
"endLine": 222,
"endChar": 22
},
"revId": "7ecb3e2ba2eabd65bcd564d5a438de97b20c9b3a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": true
}
]
}