Update patch set 5

Patch Set 5: Code-Review-1

(4 comments)

Just a couple of nits here and there

Patch-set: 5
Reviewer: Gerrit User 23567 <23567@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=-1
This commit is contained in:
Gerrit User 23567 2021-03-04 08:06:29 +00:00 committed by Gerrit Code Review
parent 882b06bbc0
commit 8179284576
1 changed files with 87 additions and 0 deletions

View File

@ -16,6 +16,93 @@
"revId": "26aff0d9254ad1e68344a573b5683af576485bae",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": true
},
{
"key": {
"uuid": "f824c0aa_e21bfc30",
"filename": "kubernetes_crds/kuryr_crds/kuryrloadbalancer.yaml",
"patchSetId": 5
},
"lineNbr": 131,
"author": {
"id": 23567
},
"writtenOn": "2021-03-04T08:06:29Z",
"side": 1,
"message": "yes, +1, the timeout should be added (if possible) to the status. It will be worthy for instance to know if annotating the SVC with a new timeout has actually updated the listener (without having to check the information on the OSP side)",
"parentUuid": "62812730_77e5c4c7",
"revId": "26aff0d9254ad1e68344a573b5683af576485bae",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": true
},
{
"key": {
"uuid": "eb3d65a7_f34776fc",
"filename": "kuryr_kubernetes/config.py",
"patchSetId": 5
},
"lineNbr": 264,
"author": {
"id": 23567
},
"writtenOn": "2021-03-04T08:06:29Z",
"side": 1,
"message": "default is whatever is defined by default on octavia side, it does not need to be 50000. Perhaps also worth to mention that setting it to \"0\" you use whatever is defined on Octavia as default",
"range": {
"startLine": 264,
"startChar": 32,
"endLine": 264,
"endChar": 38
},
"revId": "26aff0d9254ad1e68344a573b5683af576485bae",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": true
},
{
"key": {
"uuid": "d9a82165_4b9fec2f",
"filename": "kuryr_kubernetes/config.py",
"patchSetId": 5
},
"lineNbr": 268,
"author": {
"id": 23567
},
"writtenOn": "2021-03-04T08:06:29Z",
"side": 1,
"message": "ditto",
"range": {
"startLine": 268,
"startChar": 23,
"endLine": 268,
"endChar": 38
},
"revId": "26aff0d9254ad1e68344a573b5683af576485bae",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": true
},
{
"key": {
"uuid": "85180542_5dd29444",
"filename": "kuryr_kubernetes/controller/drivers/lbaasv2.py",
"patchSetId": 5
},
"lineNbr": 560,
"author": {
"id": 23567
},
"writtenOn": "2021-03-04T08:06:29Z",
"side": 1,
"message": "I think the preferred way to split lines is with (), instead of \\",
"range": {
"startLine": 560,
"startChar": 54,
"endLine": 560,
"endChar": 55
},
"revId": "26aff0d9254ad1e68344a573b5683af576485bae",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": true
}
]
}