Update patch set 1
Patch Set 1: Code-Review-1 (1 comment) For python code (and docs as well) we are using OpenStack conventions for formatting an style. That's why Zuul complained about long lines. There is a check for style Zuul has used, you can run it locally by executing `tox -e pep8`. Other than that, code looks good! Patch-set: 1 Reviewer: Gerrit User 13692 <13692@4a232e18-c5a9-48ee-94c0-e04e7cca6543> Label: Code-Review=-1
This commit is contained in:
parent
f6af5921f3
commit
9c035aceb1
|
@ -0,0 +1,21 @@
|
|||
{
|
||||
"comments": [
|
||||
{
|
||||
"key": {
|
||||
"uuid": "1af6d4ad_81811898",
|
||||
"filename": "kuryr_kubernetes/handlers/logging.py",
|
||||
"patchSetId": 1
|
||||
},
|
||||
"lineNbr": 38,
|
||||
"author": {
|
||||
"id": 13692
|
||||
},
|
||||
"writtenOn": "2021-07-22T10:31:26Z",
|
||||
"side": 1,
|
||||
"message": "It can be written like this:\n\n req_id \u003d \u0027\u0027\n if hasattr(ex, \u0027request_id\u0027):\n req_id \u003d f\u0027 [{ex.request_id}]\u0027\n LOG.exception(\"Failed to handle event%s: %s\", req_id, event)\n\nalthough I have no strong opinions.",
|
||||
"revId": "eee5ef39c075805f7ad27f9af98a39349cbed010",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": true
|
||||
}
|
||||
]
|
||||
}
|
Loading…
Reference in New Issue