Update patch set 7

Patch Set 7:

(5 comments)

A few minor remarks. The direction seems okay, I'll need to think about a few tricks to make this a bit more manageable - e.g. I don't like eventlet.spawn in a constructor, maybe there's a way to use oslo.service periodic tasks.

Patch-set: 7
CC: Gerrit User 11600 <11600@4a232e18-c5a9-48ee-94c0-e04e7cca6543>

bec38211099399eb5349fa96f28a23f68ce667ab

@@ -1,5 +1,120 @@
 {
   "comments": [
+    {
+      "key": {
+        "uuid": "af4ae042_bcc34982",
+        "filename": "kuryr_kubernetes/controller/drivers/utils.py",
+        "patchSetId": 7
+      },
+      "lineNbr": 355,
+      "author": {
+        "id": 11600
+      },
+      "writtenOn": "2021-07-02T16:28:13Z",
+      "side": 1,
+      "message": "This would spam the logs, it has to go once the code is ready.",
+      "range": {
+        "startLine": 355,
+        "startChar": 0,
+        "endLine": 355,
+        "endChar": 58
+      },
+      "revId": "bec38211099399eb5349fa96f28a23f68ce667ab",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": true
+    },
+    {
+      "key": {
+        "uuid": "d76b3717_d67778c2",
+        "filename": "kuryr_kubernetes/controller/drivers/utils.py",
+        "patchSetId": 7
+      },
+      "lineNbr": 361,
+      "author": {
+        "id": 11600
+      },
+      "writtenOn": "2021-07-02T16:28:13Z",
+      "side": 1,
+      "message": "This is mixing responsibilities, a higher layer should translate the exception.",
+      "range": {
+        "startLine": 359,
+        "startChar": 0,
+        "endLine": 361,
+        "endChar": 46
+      },
+      "revId": "bec38211099399eb5349fa96f28a23f68ce667ab",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": true
+    },
+    {
+      "key": {
+        "uuid": "72632834_b53e82aa",
+        "filename": "kuryr_kubernetes/controller/handlers/loadbalancer.py",
+        "patchSetId": 7
+      },
+      "lineNbr": 16,
+      "author": {
+        "id": 11600
+      },
+      "writtenOn": "2021-07-02T16:28:13Z",
+      "side": 1,
+      "message": "eventlet is a third-party lib, not a built-in like time. It should go into another section.",
+      "range": {
+        "startLine": 16,
+        "startChar": 7,
+        "endLine": 16,
+        "endChar": 15
+      },
+      "revId": "bec38211099399eb5349fa96f28a23f68ce667ab",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": true
+    },
+    {
+      "key": {
+        "uuid": "de63c9be_944c0454",
+        "filename": "kuryr_kubernetes/controller/handlers/loadbalancer.py",
+        "patchSetId": 7
+      },
+      "lineNbr": 126,
+      "author": {
+        "id": 11600
+      },
+      "writtenOn": "2021-07-02T16:28:13Z",
+      "side": 1,
+      "message": "Not 600?",
+      "range": {
+        "startLine": 126,
+        "startChar": 67,
+        "endLine": 126,
+        "endChar": 70
+      },
+      "revId": "bec38211099399eb5349fa96f28a23f68ce667ab",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": true
+    },
+    {
+      "key": {
+        "uuid": "319fd5c6_dbedbd1a",
+        "filename": "kuryr_kubernetes/controller/handlers/loadbalancer.py",
+        "patchSetId": 7
+      },
+      "lineNbr": 132,
+      "author": {
+        "id": 11600
+      },
+      "writtenOn": "2021-07-02T16:28:13Z",
+      "side": 1,
+      "message": "If ResourceNotReady gets raised from inside this method it\u0027ll kill the thread.",
+      "range": {
+        "startLine": 132,
+        "startChar": 45,
+        "endLine": 132,
+        "endChar": 71
+      },
+      "revId": "bec38211099399eb5349fa96f28a23f68ce667ab",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": true
+    },
     {
       "key": {
         "uuid": "377c6848_0854a19a",