openstack
/
kuryr-kubernetes
Code Issues Proposed changes

Update patch set 18 

Patch Set 18:

(1 comment)

Patch-set: 18
This commit is contained in:
Gerrit User 6598 2017-07-30 05:40:51 +00:00 committed by Gerrit Code Review
parent 800e5645f4
commit b0f582786b
1 changed files with 24 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
80d5f28ea23888e57f893dc4d151b228f7297198
View File

@ -379,6 +379,30 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "df3967d1_ae4b6585",
"filename": "kuryr_kubernetes/os_vif_plug_noop.py",
"patchSetId": 18
},
"lineNbr": 60,
"author": {
"id": 6598
},
"writtenOn": "2017-07-30T05:40:51Z",
"side": 1,
"message": "I am not sure I am following the explanation. Let\u0027s chat over IRC. In any case, seems that we can resolve it by eventually ending with less code (especially without duplication already existing one)",
"parentUuid": "1f1a1f67_8b53656b",
"range": {
"startLine": 43,
"startChar": 0,
"endLine": 60,
"endChar": 12
},
"revId": "80d5f28ea23888e57f893dc4d151b228f7297198",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "1f1a1f67_e9f0cfff",