Update patch set 6
Patch Set 6: (5 comments) Patch-set: 6 Label: Verified=0
This commit is contained in:
Gerrit User 15168
Gerrit Code Review
parent
1b25d06bc4
commit
b811d550bc
|
|
@ -23,6 +23,30 @@
|
|||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "5f201791_11b6723f",
|
||||
"filename": "kuryr_kubernetes/cni/api.py",
|
||||
"patchSetId": 6
|
||||
},
|
||||
"lineNbr": 91,
|
||||
"author": {
|
||||
"id": 15168
|
||||
},
|
||||
"writtenOn": "2017-07-10T14:01:01Z",
|
||||
"side": 1,
|
||||
"message": "In the current implementation it is possible (theoreticaly), that plugin would return None here.\nHere .add(..) would return an interface, whose name equals CNI_IFNAME. I assume for k8s its hardcoded to be eth0. If the controller sends a dict without eth0 then this code would get executed.\n\nAlso I think I\u0027ll change the order of conditions to make it more readable",
|
||||
"parentUuid": "5f201791_a0ad7332",
|
||||
"range": {
|
||||
"startLine": 89,
|
||||
"startChar": 16,
|
||||
"endLine": 91,
|
||||
"endChar": 21
|
||||
},
|
||||
"revId": "cf2e448858b3ecdcafd69218497d728890a284f4",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "5f201791_43634943",
|
||||
|
|
@ -46,6 +70,30 @@
|
|||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "5f201791_b1d9fe57",
|
||||
"filename": "kuryr_kubernetes/cni/handlers.py",
|
||||
"patchSetId": 6
|
||||
},
|
||||
"lineNbr": 50,
|
||||
"author": {
|
||||
"id": 15168
|
||||
},
|
||||
"writtenOn": "2017-07-10T14:01:01Z",
|
||||
"side": 1,
|
||||
"message": "in this patch instead of doing with a list of VIFs I\u0027m doing with a dict {ifname -\u003e vif-obj}. This will give users better control over interface naming, but implies a bit more complex logic and more edge cases.\nOne such edge case is — there would be no \u0027eth0\u0027 in the dict. In that case I simply use a random vif from the dict",
|
||||
"parentUuid": "5f201791_43634943",
|
||||
"range": {
|
||||
"startLine": 50,
|
||||
"startChar": 0,
|
||||
"endLine": 50,
|
||||
"endChar": 50
|
||||
},
|
||||
"revId": "cf2e448858b3ecdcafd69218497d728890a284f4",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "5f201791_c30e393a",
|
||||
|
|
@ -69,6 +117,30 @@
|
|||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "5f201791_11c79266",
|
||||
"filename": "kuryr_kubernetes/cni/handlers.py",
|
||||
"patchSetId": 6
|
||||
},
|
||||
"lineNbr": 52,
|
||||
"author": {
|
||||
"id": 15168
|
||||
},
|
||||
"writtenOn": "2017-07-10T14:01:01Z",
|
||||
"side": 1,
|
||||
"message": "see comment above. Most of confusion comes from assuming vifs is a list, where it\u0027s actually a dict \u003d)",
|
||||
"parentUuid": "5f201791_c30e393a",
|
||||
"range": {
|
||||
"startLine": 52,
|
||||
"startChar": 2,
|
||||
"endLine": 52,
|
||||
"endChar": 28
|
||||
},
|
||||
"revId": "cf2e448858b3ecdcafd69218497d728890a284f4",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "5f201791_738713b7",
|
||||
|
|
@ -92,6 +164,30 @@
|
|||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "5f201791_91f042ff",
|
||||
"filename": "kuryr_kubernetes/cni/handlers.py",
|
||||
"patchSetId": 6
|
||||
},
|
||||
"lineNbr": 72,
|
||||
"author": {
|
||||
"id": 15168
|
||||
},
|
||||
"writtenOn": "2017-07-10T14:01:01Z",
|
||||
"side": 1,
|
||||
"message": "Done",
|
||||
"parentUuid": "5f201791_738713b7",
|
||||
"range": {
|
||||
"startLine": 72,
|
||||
"startChar": 23,
|
||||
"endLine": 72,
|
||||
"endChar": 26
|
||||
},
|
||||
"revId": "cf2e448858b3ecdcafd69218497d728890a284f4",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "5f201791_f3f68363",
|
||||
|
|
@ -108,6 +204,24 @@
|
|||
"revId": "cf2e448858b3ecdcafd69218497d728890a284f4",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "5f201791_51de2a6d",
|
||||
"filename": "kuryr_kubernetes/cni/handlers.py",
|
||||
"patchSetId": 6
|
||||
},
|
||||
"lineNbr": 86,
|
||||
"author": {
|
||||
"id": 15168
|
||||
},
|
||||
"writtenOn": "2017-07-10T14:01:01Z",
|
||||
"side": 1,
|
||||
"message": "sure",
|
||||
"parentUuid": "5f201791_f3f68363",
|
||||
"revId": "cf2e448858b3ecdcafd69218497d728890a284f4",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
}
|
||||
]
|
||||
}
|
||||
Loading…
Reference in New Issue