openstack
/
kuryr-kubernetes
Code Issues Proposed changes

Update patch set 25 

Patch Set 25:

(1 comment)

Patch-set: 25
This commit is contained in:
Gerrit User 33240 2021-07-23 08:57:17 +00:00 committed by Gerrit Code Review
parent 349d229eac
commit bfcafce2ec
1 changed files with 24 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
e790508842493d7d32f13c94ddda76d973f2f619
View File

@ -45,6 +45,30 @@
"revId": "e790508842493d7d32f13c94ddda76d973f2f619",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": true
},
{
"key": {
"uuid": "616ece23_3d1c6dd5",
"filename": "kuryr_kubernetes/tests/unit/controller/handlers/test_loadbalancer.py",
"patchSetId": 25
},
"lineNbr": 678,
"author": {
"id": 33240
},
"writtenOn": "2021-07-23T08:57:17Z",
"side": 1,
"message": "\u003e maybe you can also assert that load_balancers is called as you\u0027re mocking the return value at line 670. (same applies for the other test case)\n\nOkay! Let me make that check",
"parentUuid": "d60efc47_aa17b9df",
"range": {
"startLine": 678,
"startChar": 35,
"endLine": 678,
"endChar": 53
},
"revId": "e790508842493d7d32f13c94ddda76d973f2f619",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": true
}
]
}