Update patch set 12

Patch Set 12:

(4 comments)

Patch-set: 12
Reviewer: Gerrit User 11600 <11600@4a232e18-c5a9-48ee-94c0-e04e7cca6543>

daddd7a77b9fa4fcb2a6e0397fe63cdd1a94aec7

@@ -23,6 +23,30 @@
       "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
       "unresolved": true
     },
+    {
+      "key": {
+        "uuid": "057f629d_a7ee52a0",
+        "filename": "devstack/lib/kuryr_kubernetes",
+        "patchSetId": 12
+      },
+      "lineNbr": 39,
+      "author": {
+        "id": 11600
+      },
+      "writtenOn": "2021-03-03T10:46:36Z",
+      "side": 1,
+      "message": "https://github.com/openstack/kuryr-kubernetes/blob/master/devstack/plugin.sh#L373",
+      "parentUuid": "583b9090_dbcd13c6",
+      "range": {
+        "startLine": 39,
+        "startChar": 25,
+        "endLine": 39,
+        "endChar": 44
+      },
+      "revId": "daddd7a77b9fa4fcb2a6e0397fe63cdd1a94aec7",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": true
+    },
     {
       "key": {
         "uuid": "1ccdc44c_b22974bb",
@@ -46,6 +70,30 @@
       "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
       "unresolved": true
     },
+    {
+      "key": {
+        "uuid": "9f0743b9_cf06d5bf",
+        "filename": "devstack/lib/kuryr_kubernetes",
+        "patchSetId": 12
+      },
+      "lineNbr": 211,
+      "author": {
+        "id": 11600
+      },
+      "writtenOn": "2021-03-03T10:46:36Z",
+      "side": 1,
+      "message": "Aw, right, my IDE used 2 spaces for some reason, I must have missed that place when updating that.",
+      "parentUuid": "1ccdc44c_b22974bb",
+      "range": {
+        "startLine": 211,
+        "startChar": 4,
+        "endLine": 211,
+        "endChar": 6
+      },
+      "revId": "daddd7a77b9fa4fcb2a6e0397fe63cdd1a94aec7",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
     {
       "key": {
         "uuid": "6229b5b3_e9b172b7",
@@ -62,6 +110,47 @@
       "revId": "daddd7a77b9fa4fcb2a6e0397fe63cdd1a94aec7",
       "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
       "unresolved": true
+    },
+    {
+      "key": {
+        "uuid": "6b6adae3_8159b86d",
+        "filename": "devstack/plugin.sh",
+        "patchSetId": 12
+      },
+      "lineNbr": 243,
+      "author": {
+        "id": 11600
+      },
+      "writtenOn": "2021-03-03T10:46:36Z",
+      "side": 1,
+      "message": "It doesn\u0027t, but it would mean we need to create 2 LBs and that\u0027s not necessary in 1.20 as default/kubernetes service stays IPv4 even if K8s is configured to do dual stack.",
+      "parentUuid": "6229b5b3_e9b172b7",
+      "revId": "daddd7a77b9fa4fcb2a6e0397fe63cdd1a94aec7",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": true
+    },
+    {
+      "key": {
+        "uuid": "37b8b04b_a0517cb7",
+        "filename": "devstack/plugin.sh",
+        "patchSetId": 12
+      },
+      "lineNbr": 537,
+      "author": {
+        "id": 11600
+      },
+      "writtenOn": "2021-03-03T10:46:36Z",
+      "side": 1,
+      "message": "Same here BTW - we don\u0027t know what IP will dual stack `default/kubernetes` service ever get. It would be logical to be the first one of IPv6 subnet but no need to set it now.",
+      "range": {
+        "startLine": 534,
+        "startChar": 0,
+        "endLine": 537,
+        "endChar": 46
+      },
+      "revId": "daddd7a77b9fa4fcb2a6e0397fe63cdd1a94aec7",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": true
     }
   ]
 }