Update patch set 2
Patch Set 2: Code-Review-1 (1 comment) Patch-set: 2 Reviewer: Gerrit User 23567 <23567@4a232e18-c5a9-48ee-94c0-e04e7cca6543> Label: Code-Review=-1
This commit is contained in:
parent
c7e42d6841
commit
e1c7fd9212
|
@ -0,0 +1,27 @@
|
|||
{
|
||||
"comments": [
|
||||
{
|
||||
"key": {
|
||||
"uuid": "8794c4d5_c11bcb00",
|
||||
"filename": "kuryr_kubernetes/config.py",
|
||||
"patchSetId": 2
|
||||
},
|
||||
"lineNbr": 265,
|
||||
"author": {
|
||||
"id": 23567
|
||||
},
|
||||
"writtenOn": "2021-03-01T09:12:02Z",
|
||||
"side": 1,
|
||||
"message": "I would perhaps not set any default to these, and in case it is not set, we simply use the default value (i.e., not passing any timeout information while creating the listeners), rather than modify the default to 50000",
|
||||
"range": {
|
||||
"startLine": 265,
|
||||
"startChar": 15,
|
||||
"endLine": 265,
|
||||
"endChar": 28
|
||||
},
|
||||
"revId": "6e7dc1bcb582c040d7fca12acf07b5cdd486b0e2",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": true
|
||||
}
|
||||
]
|
||||
}
|
Loading…
Reference in New Issue