Update patch set 2

Browse Source

Patch Set 2:

> Patch Set 2:
> 
> > Patch Set 2: Code-Review-1
> > 
> > Thanks for the update. It’s still needed to also retrieve the timeouts value from a possible annotation that the user adds to the Service. Note that the user may not be allowed to modify the config-map that is why we need to add support to reading from annotation. We can also include in the docs what is the name of annotation.
> 
> By annotating the service, do you mean for example adding timeout fields to the service manifest?

yes, we need to handle the timeout annotation on the Service's metadata[1] that the user could add. The kuryrLoadBalancer CRD could then be filled with either the default value or the value set by the User on the annotation. Note that Kuryr already reads annotations from the Pods on the PodLabelHandler for example.

[1] https://kubernetes.io/docs/concepts/overview/working-with-objects/annotations/

Patch-set: 2
Reviewer: Gerrit User 27032 <27032@4a232e18-c5a9-48ee-94c0-e04e7cca6543>

...

This commit is contained in:

Gerrit User 27032 2021-02-26 15:07:19 +00:00 committed by Gerrit Code Review

parent 1ac37d32d9

commit ef15b531cf

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Show Stats Download Patch File Download Diff File Expand all files Collapse all files

Diff Content Not Available