openstack
/
kuryr-kubernetes
Code Issues Proposed changes

Update patch set 10 

Patch Set 10:

(3 comments)

working on updating the patch, thanks for review

Patch-set: 10
Label: Verified=0
This commit is contained in:
Gerrit User 15168 2017-07-13 06:56:11 +00:00 committed by Gerrit Code Review
parent 197ac61ec5
commit ffa2a26e0c
1 changed files with 72 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

72
7939ed76cf6200c87d1a96c2289c85ad1d07184e
View File

@ -23,6 +23,30 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "1f1a1f67_03d3553a",
"filename": "kuryr_kubernetes/controller/handlers/vif.py",
"patchSetId": 10
},
"lineNbr": 64,
"author": {
"id": 15168
},
"writtenOn": "2017-07-13T06:56:11Z",
"side": 1,
"message": "yeah, looks like you\u0027re right",
"parentUuid": "1f1a1f67_e0c28fe9",
"range": {
"startLine": 63,
"startChar": 0,
"endLine": 64,
"endChar": 75
},
"revId": "7939ed76cf6200c87d1a96c2289c85ad1d07184e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "1f1a1f67_2319b178",
@ -46,6 +70,30 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "1f1a1f67_83940546",
"filename": "kuryr_kubernetes/controller/handlers/vif.py",
"patchSetId": 10
},
"lineNbr": 74,
"author": {
"id": 15168
},
"writtenOn": "2017-07-13T06:56:11Z",
"side": 1,
"message": "well this patch does not yet offer a way to request others, I can add relevant comment here",
"parentUuid": "1f1a1f67_2319b178",
"range": {
"startLine": 66,
"startChar": 0,
"endLine": 74,
"endChar": 41
},
"revId": "7939ed76cf6200c87d1a96c2289c85ad1d07184e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "1f1a1f67_4007031e",
@ -91,6 +139,30 @@
"revId": "7939ed76cf6200c87d1a96c2289c85ad1d07184e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "1f1a1f67_038fd523",
"filename": "kuryr_kubernetes/controller/handlers/vif.py",
"patchSetId": 10
},
"lineNbr": 102,
"author": {
"id": 15168
},
"writtenOn": "2017-07-13T06:56:11Z",
"side": 1,
"message": "I\u0027d rather use this on L80, than not. I needed this to deferentiate between pool and sriov drivers. Can move it to a different commit, but it feels like a more generic thing to be added to sriov patch.",
"parentUuid": "1f1a1f67_a0181781",
"range": {
"startLine": 102,
"startChar": 8,
"endLine": 102,
"endChar": 20
},
"revId": "7939ed76cf6200c87d1a96c2289c85ad1d07184e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}