kuryr-kubernetes/95d52390363338c6c5b167ec2de7b0be112340bc

{
  "comments": [
    {
      "key": {
        "uuid": "7f231b9d_54ef451d",
        "filename": "kuryr_kubernetes/cni/handlers.py",
        "patchSetId": 5
      },
      "lineNbr": 104,
      "author": {
        "id": 23567
      },
      "writtenOn": "2017-06-19T15:16:06Z",
      "side": 1,
      "message": "is this used?",
      "range": {
        "startLine": 104,
        "startChar": 29,
        "endLine": 104,
        "endChar": 37
      },
      "revId": "95d52390363338c6c5b167ec2de7b0be112340bc",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": false
    },
    {
      "key": {
        "uuid": "7f231b9d_675a2d84",
        "filename": "kuryr_kubernetes/cni/handlers.py",
        "patchSetId": 5
      },
      "lineNbr": 104,
      "author": {
        "id": 15168
      },
      "writtenOn": "2017-06-20T04:56:51Z",
      "side": 1,
      "message": "it is. see L86",
      "parentUuid": "7f231b9d_54ef451d",
      "range": {
        "startLine": 104,
        "startChar": 29,
        "endLine": 104,
        "endChar": 37
      },
      "revId": "95d52390363338c6c5b167ec2de7b0be112340bc",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": false
    },
    {
      "key": {
        "uuid": "7f231b9d_fdd266ff",
        "filename": "kuryr_kubernetes/controller/handlers/vif.py",
        "patchSetId": 5
      },
      "lineNbr": 71,
      "author": {
        "id": 23567
      },
      "writtenOn": "2017-06-19T15:16:06Z",
      "side": 1,
      "message": "perhaps this should be a config (parametrizable) option",
      "range": {
        "startLine": 71,
        "startChar": 17,
        "endLine": 71,
        "endChar": 22
      },
      "revId": "95d52390363338c6c5b167ec2de7b0be112340bc",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": false
    },
    {
      "key": {
        "uuid": "7f231b9d_c74a21ab",
        "filename": "kuryr_kubernetes/controller/handlers/vif.py",
        "patchSetId": 5
      },
      "lineNbr": 71,
      "author": {
        "id": 15168
      },
      "writtenOn": "2017-06-20T04:56:51Z",
      "side": 1,
      "message": "maybe a constant in constants.py, but I would be against parametrising this. it\u0027s hardcoded in k8s as well.\n\nhttps://github.com/kubernetes/kubernetes/blob/8fd414537b5143ab039cb910590237cabf4af783/pkg/kubelet/network/network.go",
      "parentUuid": "7f231b9d_fdd266ff",
      "range": {
        "startLine": 71,
        "startChar": 17,
        "endLine": 71,
        "endChar": 22
      },
      "revId": "95d52390363338c6c5b167ec2de7b0be112340bc",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": false
    },
    {
      "key": {
        "uuid": "7f231b9d_3dfe9e6a",
        "filename": "kuryr_kubernetes/controller/handlers/vif.py",
        "patchSetId": 5
      },
      "lineNbr": 79,
      "author": {
        "id": 23567
      },
      "writtenOn": "2017-06-19T15:16:06Z",
      "side": 1,
      "message": "will vifs have more than one item at any point when reaching this point?",
      "range": {
        "startLine": 79,
        "startChar": 35,
        "endLine": 79,
        "endChar": 47
      },
      "revId": "95d52390363338c6c5b167ec2de7b0be112340bc",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": false
    },
    {
      "key": {
        "uuid": "7f231b9d_a7ee0589",
        "filename": "kuryr_kubernetes/controller/handlers/vif.py",
        "patchSetId": 5
      },
      "lineNbr": 79,
      "author": {
        "id": 15168
      },
      "writtenOn": "2017-06-20T04:56:51Z",
      "side": 1,
      "message": "not in this patch, but yes. that\u0027s what we\u0027ve been discussing. The SRIOV interfaces are going to be passed via the same annotation as the main interface. this patch paves the way for the next two, adding actual SRIOV capabilities. Also this paves the way for requesting multiple VIFs from multiple subnets. This particular patch does not introduce the mechanism to request multiple VIFs, just the mechanism to pass multiple VIFs from controller to CNI",
      "parentUuid": "7f231b9d_3dfe9e6a",
      "range": {
        "startLine": 79,
        "startChar": 35,
        "endLine": 79,
        "endChar": 47
      },
      "revId": "95d52390363338c6c5b167ec2de7b0be112340bc",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": false
    }
  ]
}