kuryr-kubernetes/cf2e448858b3ecdcafd69218497d728890a284f4

{
  "comments": [
    {
      "key": {
        "uuid": "5f201791_a0ad7332",
        "filename": "kuryr_kubernetes/cni/api.py",
        "patchSetId": 6
      },
      "lineNbr": 91,
      "author": {
        "id": 15967
      },
      "writtenOn": "2017-06-23T11:19:38Z",
      "side": 1,
      "message": "is this change related to multi-vif specifically or a general improvement?",
      "range": {
        "startLine": 89,
        "startChar": 16,
        "endLine": 91,
        "endChar": 21
      },
      "revId": "cf2e448858b3ecdcafd69218497d728890a284f4",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": false
    },
    {
      "key": {
        "uuid": "5f201791_11b6723f",
        "filename": "kuryr_kubernetes/cni/api.py",
        "patchSetId": 6
      },
      "lineNbr": 91,
      "author": {
        "id": 15168
      },
      "writtenOn": "2017-07-10T14:01:01Z",
      "side": 1,
      "message": "In the current implementation it is possible (theoreticaly), that plugin would return None here.\nHere .add(..) would return an interface, whose name equals CNI_IFNAME. I assume for k8s its hardcoded to be eth0. If the controller sends a dict without eth0 then this code would get executed.\n\nAlso I think I\u0027ll change the order of conditions to make it more readable",
      "parentUuid": "5f201791_a0ad7332",
      "range": {
        "startLine": 89,
        "startChar": 16,
        "endLine": 91,
        "endChar": 21
      },
      "revId": "cf2e448858b3ecdcafd69218497d728890a284f4",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": false
    },
    {
      "key": {
        "uuid": "5f201791_43634943",
        "filename": "kuryr_kubernetes/cni/handlers.py",
        "patchSetId": 6
      },
      "lineNbr": 50,
      "author": {
        "id": 15967
      },
      "writtenOn": "2017-06-23T11:19:38Z",
      "side": 1,
      "message": "Can you please explain what this check is for? \n\nIn current code, self._cni.CNI_IFNAME is \u0027eth0\u0027 and vif.name will never be in this form. or i miss something?\n\nIn multi-vif case also, this should have been a list of iface names.",
      "range": {
        "startLine": 50,
        "startChar": 0,
        "endLine": 50,
        "endChar": 50
      },
      "revId": "cf2e448858b3ecdcafd69218497d728890a284f4",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": false
    },
    {
      "key": {
        "uuid": "5f201791_b1d9fe57",
        "filename": "kuryr_kubernetes/cni/handlers.py",
        "patchSetId": 6
      },
      "lineNbr": 50,
      "author": {
        "id": 15168
      },
      "writtenOn": "2017-07-10T14:01:01Z",
      "side": 1,
      "message": "in this patch instead of doing with a list of VIFs I\u0027m doing with a dict {ifname -\u003e vif-obj}. This will give users better control over interface naming, but implies a bit more complex logic and more edge cases.\nOne such edge case is — there would be no \u0027eth0\u0027 in the dict. In that case I simply use a random vif from the dict",
      "parentUuid": "5f201791_43634943",
      "range": {
        "startLine": 50,
        "startChar": 0,
        "endLine": 50,
        "endChar": 50
      },
      "revId": "cf2e448858b3ecdcafd69218497d728890a284f4",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": false
    },
    {
      "key": {
        "uuid": "5f201791_c30e393a",
        "filename": "kuryr_kubernetes/cni/handlers.py",
        "patchSetId": 6
      },
      "lineNbr": 52,
      "author": {
        "id": 15967
      },
      "writtenOn": "2017-06-23T11:19:38Z",
      "side": 1,
      "message": "based on above comment, i see that this will always execute and here seems you are assuming that first vif will be corresponding to the primary interface of the pod. Am i right? If yes, how and where is this order ,that first will be primary, is being guaranteed?",
      "range": {
        "startLine": 52,
        "startChar": 2,
        "endLine": 52,
        "endChar": 28
      },
      "revId": "cf2e448858b3ecdcafd69218497d728890a284f4",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": false
    },
    {
      "key": {
        "uuid": "5f201791_11c79266",
        "filename": "kuryr_kubernetes/cni/handlers.py",
        "patchSetId": 6
      },
      "lineNbr": 52,
      "author": {
        "id": 15168
      },
      "writtenOn": "2017-07-10T14:01:01Z",
      "side": 1,
      "message": "see comment above. Most of confusion comes from assuming vifs is a list, where it\u0027s actually a dict \u003d)",
      "parentUuid": "5f201791_c30e393a",
      "range": {
        "startLine": 52,
        "startChar": 2,
        "endLine": 52,
        "endChar": 28
      },
      "revId": "cf2e448858b3ecdcafd69218497d728890a284f4",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": false
    },
    {
      "key": {
        "uuid": "5f201791_738713b7",
        "filename": "kuryr_kubernetes/cni/handlers.py",
        "patchSetId": 6
      },
      "lineNbr": 72,
      "author": {
        "id": 6598
      },
      "writtenOn": "2017-06-26T06:00:58Z",
      "side": 1,
      "message": "VIFs",
      "range": {
        "startLine": 72,
        "startChar": 23,
        "endLine": 72,
        "endChar": 26
      },
      "revId": "cf2e448858b3ecdcafd69218497d728890a284f4",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": false
    },
    {
      "key": {
        "uuid": "5f201791_91f042ff",
        "filename": "kuryr_kubernetes/cni/handlers.py",
        "patchSetId": 6
      },
      "lineNbr": 72,
      "author": {
        "id": 15168
      },
      "writtenOn": "2017-07-10T14:01:01Z",
      "side": 1,
      "message": "Done",
      "parentUuid": "5f201791_738713b7",
      "range": {
        "startLine": 72,
        "startChar": 23,
        "endLine": 72,
        "endChar": 26
      },
      "revId": "cf2e448858b3ecdcafd69218497d728890a284f4",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": false
    },
    {
      "key": {
        "uuid": "5f201791_f3f68363",
        "filename": "kuryr_kubernetes/cni/handlers.py",
        "patchSetId": 6
      },
      "lineNbr": 86,
      "author": {
        "id": 6598
      },
      "writtenOn": "2017-06-26T06:00:58Z",
      "side": 1,
      "message": "please add docstring",
      "revId": "cf2e448858b3ecdcafd69218497d728890a284f4",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": false
    },
    {
      "key": {
        "uuid": "5f201791_51de2a6d",
        "filename": "kuryr_kubernetes/cni/handlers.py",
        "patchSetId": 6
      },
      "lineNbr": 86,
      "author": {
        "id": 15168
      },
      "writtenOn": "2017-07-10T14:01:01Z",
      "side": 1,
      "message": "sure",
      "parentUuid": "5f201791_f3f68363",
      "revId": "cf2e448858b3ecdcafd69218497d728890a284f4",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": false
    }
  ]
}