144 lines
4.5 KiB
Plaintext
144 lines
4.5 KiB
Plaintext
{
|
|
"comments": [
|
|
{
|
|
"key": {
|
|
"uuid": "b166996c_924dbaf8",
|
|
"filename": "kuryr_kubernetes/controller/drivers/utils.py",
|
|
"patchSetId": 2
|
|
},
|
|
"lineNbr": 345,
|
|
"author": {
|
|
"id": 23567
|
|
},
|
|
"writtenOn": "2021-07-01T06:45:59Z",
|
|
"side": 1,
|
|
"message": "this function is exactly the same as the one defined in line 325. Perhaps a base function can be created that both calls to avoid code repetition",
|
|
"range": {
|
|
"startLine": 345,
|
|
"startChar": 4,
|
|
"endLine": 345,
|
|
"endChar": 30
|
|
},
|
|
"revId": "40ff64db5b4806382e0f8909af1ff3ffaa493aa2",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": true
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "28ee656d_72fe522b",
|
|
"filename": "kuryr_kubernetes/controller/drivers/utils.py",
|
|
"patchSetId": 2
|
|
},
|
|
"lineNbr": 345,
|
|
"author": {
|
|
"id": 33240
|
|
},
|
|
"writtenOn": "2021-07-01T07:05:43Z",
|
|
"side": 1,
|
|
"message": "\u003e this function is exactly the same as the one defined in line 325. Perhaps a base function can be created that both calls to avoid code repetition\n\nLet me find a way around it, so the URL would be generic sort of",
|
|
"parentUuid": "b166996c_924dbaf8",
|
|
"range": {
|
|
"startLine": 345,
|
|
"startChar": 4,
|
|
"endLine": 345,
|
|
"endChar": 30
|
|
},
|
|
"revId": "40ff64db5b4806382e0f8909af1ff3ffaa493aa2",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": true
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "6b2d8903_09cf4b94",
|
|
"filename": "kuryr_kubernetes/controller/drivers/utils.py",
|
|
"patchSetId": 2
|
|
},
|
|
"lineNbr": 345,
|
|
"author": {
|
|
"id": 33240
|
|
},
|
|
"writtenOn": "2021-07-02T15:06:20Z",
|
|
"side": 1,
|
|
"message": "\u003e \u003e this function is exactly the same as the one defined in line 325. Perhaps a base function can be created that both calls to avoid code repetition\n\u003e \n\u003e Let me find a way around it, so the URL would be generic sort of\n\nI will focus on this once I am done with the reconciliation handling",
|
|
"parentUuid": "28ee656d_72fe522b",
|
|
"range": {
|
|
"startLine": 345,
|
|
"startChar": 4,
|
|
"endLine": 345,
|
|
"endChar": 30
|
|
},
|
|
"revId": "40ff64db5b4806382e0f8909af1ff3ffaa493aa2",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": true
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "64c779b7_fa33e489",
|
|
"filename": "kuryr_kubernetes/controller/handlers/loadbalancer.py",
|
|
"patchSetId": 2
|
|
},
|
|
"lineNbr": 129,
|
|
"author": {
|
|
"id": 23567
|
|
},
|
|
"writtenOn": "2021-07-01T06:45:59Z",
|
|
"side": 1,
|
|
"message": "remember removing this before submitting the patch sets",
|
|
"range": {
|
|
"startLine": 129,
|
|
"startChar": 8,
|
|
"endLine": 129,
|
|
"endChar": 35
|
|
},
|
|
"revId": "40ff64db5b4806382e0f8909af1ff3ffaa493aa2",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": true
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "33ca183d_aa619aeb",
|
|
"filename": "kuryr_kubernetes/controller/handlers/loadbalancer.py",
|
|
"patchSetId": 2
|
|
},
|
|
"lineNbr": 142,
|
|
"author": {
|
|
"id": 23567
|
|
},
|
|
"writtenOn": "2021-07-01T06:45:59Z",
|
|
"side": 1,
|
|
"message": "this can be simplified with list comprehension",
|
|
"range": {
|
|
"startLine": 138,
|
|
"startChar": 0,
|
|
"endLine": 142,
|
|
"endChar": 59
|
|
},
|
|
"revId": "40ff64db5b4806382e0f8909af1ff3ffaa493aa2",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": true
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "626be659_8836562d",
|
|
"filename": "kuryr_kubernetes/controller/handlers/loadbalancer.py",
|
|
"patchSetId": 2
|
|
},
|
|
"lineNbr": 148,
|
|
"author": {
|
|
"id": 23567
|
|
},
|
|
"writtenOn": "2021-07-01T06:45:59Z",
|
|
"side": 1,
|
|
"message": "this is wrong, lbs_id is another list. You need to iterate on lbs_id, and check if each id in lbs_id is present in the list of ids on the openstack side (loadbalancers_id)",
|
|
"range": {
|
|
"startLine": 148,
|
|
"startChar": 12,
|
|
"endLine": 148,
|
|
"endChar": 46
|
|
},
|
|
"revId": "40ff64db5b4806382e0f8909af1ff3ffaa493aa2",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": true
|
|
}
|
|
]
|
|
} |