kuryr-kubernetes/c943b973e562603cb15893f62ffb84bc76a79a61

{
  "comments": [
    {
      "key": {
        "uuid": "d22e047e_580ea847",
        "filename": "kuryr_kubernetes/controller/handlers/loadbalancer.py",
        "patchSetId": 5
      },
      "lineNbr": 34,
      "author": {
        "id": 23567
      },
      "writtenOn": "2021-07-02T06:53:49Z",
      "side": 1,
      "message": "this should be way bigger, perhaps 10 mins",
      "range": {
        "startLine": 34,
        "startChar": 0,
        "endLine": 34,
        "endChar": 44
      },
      "revId": "c943b973e562603cb15893f62ffb84bc76a79a61",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": true
    },
    {
      "key": {
        "uuid": "43f983bb_63216f8b",
        "filename": "kuryr_kubernetes/controller/handlers/loadbalancer.py",
        "patchSetId": 5
      },
      "lineNbr": 121,
      "author": {
        "id": 23567
      },
      "writtenOn": "2021-07-02T06:53:49Z",
      "side": 1,
      "message": "this should use the global var you defined instead",
      "range": {
        "startLine": 121,
        "startChar": 12,
        "endLine": 121,
        "endChar": 30
      },
      "revId": "c943b973e562603cb15893f62ffb84bc76a79a61",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": true
    },
    {
      "key": {
        "uuid": "3cd3f291_b3f369fc",
        "filename": "kuryr_kubernetes/controller/handlers/loadbalancer.py",
        "patchSetId": 5
      },
      "lineNbr": 138,
      "author": {
        "id": 23567
      },
      "writtenOn": "2021-07-02T06:53:49Z",
      "side": 1,
      "message": "this should use .get(...) calls instead to avoid exceptions if status if empty",
      "range": {
        "startLine": 137,
        "startChar": 32,
        "endLine": 138,
        "endChar": 38
      },
      "revId": "c943b973e562603cb15893f62ffb84bc76a79a61",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": true
    },
    {
      "key": {
        "uuid": "2bf9808b_e6a94d16",
        "filename": "kuryr_kubernetes/controller/handlers/loadbalancer.py",
        "patchSetId": 5
      },
      "lineNbr": 153,
      "author": {
        "id": 23567
      },
      "writtenOn": "2021-07-02T06:53:49Z",
      "side": 1,
      "message": "this is the same as \"if crds_to_reconcile\"\n\nIn fact you don\u0027t even need the if. The loop for will take care of it",
      "range": {
        "startLine": 153,
        "startChar": 8,
        "endLine": 153,
        "endChar": 47
      },
      "revId": "c943b973e562603cb15893f62ffb84bc76a79a61",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": true
    },
    {
      "key": {
        "uuid": "1fd61089_86500bc2",
        "filename": "kuryr_kubernetes/controller/handlers/loadbalancer.py",
        "patchSetId": 5
      },
      "lineNbr": 154,
      "author": {
        "id": 27032
      },
      "writtenOn": "2021-07-02T10:00:58Z",
      "side": 1,
      "message": "This loop can be avoided if you use the loop at line 149.",
      "revId": "c943b973e562603cb15893f62ffb84bc76a79a61",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": true
    },
    {
      "key": {
        "uuid": "147d1b27_6e63f583",
        "filename": "kuryr_kubernetes/controller/handlers/loadbalancer.py",
        "patchSetId": 5
      },
      "lineNbr": 163,
      "author": {
        "id": 23567
      },
      "writtenOn": "2021-07-02T06:53:49Z",
      "side": 1,
      "message": "this looks wrong. Idea is that either there is CRDS to reconcile (if on line 153), or there aren\u0027t. In the case there is not, a simple LOG.debug message saying something like KuryrLoadBalancer CRDs already in sync should be enough",
      "range": {
        "startLine": 157,
        "startChar": 1,
        "endLine": 163,
        "endChar": 18
      },
      "revId": "c943b973e562603cb15893f62ffb84bc76a79a61",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": true
    },
    {
      "key": {
        "uuid": "879a6c0c_90893d64",
        "filename": "kuryr_kubernetes/controller/handlers/loadbalancer.py",
        "patchSetId": 5
      },
      "lineNbr": 167,
      "author": {
        "id": 23567
      },
      "writtenOn": "2021-07-02T06:53:49Z",
      "side": 1,
      "message": "waiting to see the implementation of this function! :)",
      "range": {
        "startLine": 166,
        "startChar": 0,
        "endLine": 167,
        "endChar": 16
      },
      "revId": "c943b973e562603cb15893f62ffb84bc76a79a61",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": true
    }
  ]
}