kuryr-kubernetes/ec85a19a058c68f099b7ef2ed33d3097381e629f

{
  "comments": [
    {
      "key": {
        "uuid": "49f69db8_3268fbb2",
        "filename": "kuryr_kubernetes/controller/drivers/utils.py",
        "patchSetId": 14
      },
      "lineNbr": 346,
      "author": {
        "id": 27032
      },
      "writtenOn": "2021-07-13T09:53:58Z",
      "side": 1,
      "message": "the path already holds the information about which resource if being fetched, so I guess this is not needed",
      "range": {
        "startLine": 346,
        "startChar": 4,
        "endLine": 346,
        "endChar": 8
      },
      "revId": "ec85a19a058c68f099b7ef2ed33d3097381e629f",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": true
    },
    {
      "key": {
        "uuid": "27aa45ce_dd199020",
        "filename": "kuryr_kubernetes/controller/drivers/utils.py",
        "patchSetId": 14
      },
      "lineNbr": 355,
      "author": {
        "id": 27032
      },
      "writtenOn": "2021-07-13T09:53:58Z",
      "side": 1,
      "message": "get_k8s_resource might fit better as the method can also collect any k8s native resource",
      "range": {
        "startLine": 355,
        "startChar": 4,
        "endLine": 355,
        "endChar": 25
      },
      "revId": "ec85a19a058c68f099b7ef2ed33d3097381e629f",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": true
    },
    {
      "key": {
        "uuid": "975849f7_ffe97fa9",
        "filename": "kuryr_kubernetes/controller/drivers/utils.py",
        "patchSetId": 14
      },
      "lineNbr": 357,
      "author": {
        "id": 27032
      },
      "writtenOn": "2021-07-13T09:53:58Z",
      "side": 1,
      "message": "what would this variable name mean?\nmaybe rephrase to k8s_resource?",
      "range": {
        "startLine": 357,
        "startChar": 4,
        "endLine": 357,
        "endChar": 9
      },
      "revId": "ec85a19a058c68f099b7ef2ed33d3097381e629f",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": true
    },
    {
      "key": {
        "uuid": "656382f0_f4037834",
        "filename": "kuryr_kubernetes/controller/drivers/utils.py",
        "patchSetId": 14
      },
      "lineNbr": 360,
      "author": {
        "id": 27032
      },
      "writtenOn": "2021-07-13T09:53:58Z",
      "side": 1,
      "message": "No need to add this log as it\u0027s already logged inside the get method\nhttps://github.com/openstack/kuryr-kubernetes/blob/master/kuryr_kubernetes/k8s_client.py#L115",
      "range": {
        "startLine": 360,
        "startChar": 8,
        "endLine": 360,
        "endChar": 64
      },
      "revId": "ec85a19a058c68f099b7ef2ed33d3097381e629f",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": true
    },
    {
      "key": {
        "uuid": "79565a30_0e47f522",
        "filename": "kuryr_kubernetes/controller/drivers/utils.py",
        "patchSetId": 14
      },
      "lineNbr": 360,
      "author": {
        "id": 33240
      },
      "writtenOn": "2021-07-13T11:30:13Z",
      "side": 1,
      "message": "\u003e No need to add this log as it\u0027s already logged inside the get method\n\u003e https://github.com/openstack/kuryr-kubernetes/blob/master/kuryr_kubernetes/k8s_client.py#L115\n\nGot it!",
      "parentUuid": "656382f0_f4037834",
      "range": {
        "startLine": 360,
        "startChar": 8,
        "endLine": 360,
        "endChar": 64
      },
      "revId": "ec85a19a058c68f099b7ef2ed33d3097381e629f",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": true
    },
    {
      "key": {
        "uuid": "f46c2fdb_0e2b7acd",
        "filename": "kuryr_kubernetes/controller/handlers/loadbalancer.py",
        "patchSetId": 14
      },
      "lineNbr": 126,
      "author": {
        "id": 27032
      },
      "writtenOn": "2021-07-13T09:53:58Z",
      "side": 1,
      "message": "this exception will never be raised as you\u0027re raising ResourceNotReady on get_kuryrloadbalancer_crds when it happen. Might be better to not raise ResourceNotReady.",
      "range": {
        "startLine": 126,
        "startChar": 25,
        "endLine": 126,
        "endChar": 43
      },
      "revId": "ec85a19a058c68f099b7ef2ed33d3097381e629f",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": true
    },
    {
      "key": {
        "uuid": "343d7a04_2c1916dc",
        "filename": "kuryr_kubernetes/controller/handlers/loadbalancer.py",
        "patchSetId": 14
      },
      "lineNbr": 141,
      "author": {
        "id": 27032
      },
      "writtenOn": "2021-07-13T09:53:58Z",
      "side": 1,
      "message": "could this be converted to a dict instead?",
      "range": {
        "startLine": 139,
        "startChar": 32,
        "endLine": 141,
        "endChar": 70
      },
      "revId": "ec85a19a058c68f099b7ef2ed33d3097381e629f",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": true
    },
    {
      "key": {
        "uuid": "bdda20b1_5b4ea9f1",
        "filename": "kuryr_kubernetes/controller/handlers/loadbalancer.py",
        "patchSetId": 14
      },
      "lineNbr": 156,
      "author": {
        "id": 27032
      },
      "writtenOn": "2021-07-13T09:53:58Z",
      "side": 1,
      "message": "sync with OpenStack",
      "range": {
        "startLine": 156,
        "startChar": 57,
        "endLine": 156,
        "endChar": 61
      },
      "revId": "ec85a19a058c68f099b7ef2ed33d3097381e629f",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": true
    }
  ]
}