119 lines
3.3 KiB
Plaintext
119 lines
3.3 KiB
Plaintext
{
|
|
"comments": [
|
|
{
|
|
"key": {
|
|
"uuid": "7ca10066_6e996d14",
|
|
"filename": "kuryr_kubernetes/controller/drivers/utils.py",
|
|
"patchSetId": 4
|
|
},
|
|
"lineNbr": 354,
|
|
"author": {
|
|
"id": 27032
|
|
},
|
|
"writtenOn": "2021-07-01T18:17:31Z",
|
|
"side": 1,
|
|
"message": "Shouldn\u0027t we retrieve all CRDs regardless of Namespace?",
|
|
"range": {
|
|
"startLine": 349,
|
|
"startChar": 0,
|
|
"endLine": 354,
|
|
"endChar": 39
|
|
},
|
|
"revId": "ef6be4576b9f0b78bb905086e06dfdd67e49ec48",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": true
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "bc519322_b5e13f1b",
|
|
"filename": "kuryr_kubernetes/controller/handlers/loadbalancer.py",
|
|
"patchSetId": 4
|
|
},
|
|
"lineNbr": 121,
|
|
"author": {
|
|
"id": 27032
|
|
},
|
|
"writtenOn": "2021-07-01T18:16:05Z",
|
|
"side": 1,
|
|
"message": "The value of retry might be too small, we don\u0027t want frequent openstack calls. Should this be used CRD_RECONCILIATION_FREQUENCY?",
|
|
"range": {
|
|
"startLine": 121,
|
|
"startChar": 27,
|
|
"endLine": 121,
|
|
"endChar": 29
|
|
},
|
|
"revId": "ef6be4576b9f0b78bb905086e06dfdd67e49ec48",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": true
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "79d02312_21f2e93a",
|
|
"filename": "kuryr_kubernetes/controller/handlers/loadbalancer.py",
|
|
"patchSetId": 4
|
|
},
|
|
"lineNbr": 136,
|
|
"author": {
|
|
"id": 27032
|
|
},
|
|
"writtenOn": "2021-07-01T18:16:05Z",
|
|
"side": 1,
|
|
"message": "It\u0027s not safe to directly access the keys of the dict (crd might not a lb yet), better to use .get()",
|
|
"range": {
|
|
"startLine": 136,
|
|
"startChar": 18,
|
|
"endLine": 136,
|
|
"endChar": 53
|
|
},
|
|
"revId": "ef6be4576b9f0b78bb905086e06dfdd67e49ec48",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": true
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "44b7467b_75d260f2",
|
|
"filename": "kuryr_kubernetes/controller/handlers/loadbalancer.py",
|
|
"patchSetId": 4
|
|
},
|
|
"lineNbr": 143,
|
|
"author": {
|
|
"id": 23567
|
|
},
|
|
"writtenOn": "2021-07-01T13:09:49Z",
|
|
"side": 1,
|
|
"message": "this should be the other way around... looking for each of the loadbalancer ids in lbs_id that are not in loadbalanacers_id",
|
|
"range": {
|
|
"startLine": 143,
|
|
"startChar": 0,
|
|
"endLine": 143,
|
|
"endChar": 42
|
|
},
|
|
"revId": "ef6be4576b9f0b78bb905086e06dfdd67e49ec48",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": true
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "793f0264_b489a8ad",
|
|
"filename": "kuryr_kubernetes/controller/handlers/loadbalancer.py",
|
|
"patchSetId": 4
|
|
},
|
|
"lineNbr": 148,
|
|
"author": {
|
|
"id": 27032
|
|
},
|
|
"writtenOn": "2021-07-01T18:16:05Z",
|
|
"side": 1,
|
|
"message": "Kubernetes Services",
|
|
"range": {
|
|
"startLine": 148,
|
|
"startChar": 61,
|
|
"endLine": 148,
|
|
"endChar": 72
|
|
},
|
|
"revId": "ef6be4576b9f0b78bb905086e06dfdd67e49ec48",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": true
|
|
}
|
|
]
|
|
} |