61 lines
2.1 KiB
Plaintext
61 lines
2.1 KiB
Plaintext
{
|
|
"comments": [
|
|
{
|
|
"key": {
|
|
"uuid": "e058df18_62708539",
|
|
"filename": "kuryr_kubernetes/tests/unit/controller/handlers/test_loadbalancer.py",
|
|
"patchSetId": 20
|
|
},
|
|
"lineNbr": 140,
|
|
"author": {
|
|
"id": 27032
|
|
},
|
|
"writtenOn": "2021-07-19T08:55:51Z",
|
|
"side": 1,
|
|
"message": "Lines that are not used on the unit test could be removed, like listeners, pools, members, some on the spec and a few on metadata",
|
|
"range": {
|
|
"startLine": 140,
|
|
"startChar": 4,
|
|
"endLine": 140,
|
|
"endChar": 15
|
|
},
|
|
"revId": "f8e8aba14e6a4eb3364ea9836b4fb1889c4c20b2",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": true
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "151bef16_acffc6fb",
|
|
"filename": "kuryr_kubernetes/tests/unit/controller/handlers/test_loadbalancer.py",
|
|
"patchSetId": 20
|
|
},
|
|
"lineNbr": 818,
|
|
"author": {
|
|
"id": 27032
|
|
},
|
|
"writtenOn": "2021-07-19T08:55:51Z",
|
|
"side": 1,
|
|
"message": "You need to call the function _reconcile_loadbalancers, otherwise the test won\u0027t exercise any corner cases on that function, similar to how is done at line 808.",
|
|
"revId": "f8e8aba14e6a4eb3364ea9836b4fb1889c4c20b2",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": true
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "b4582484_d771d56e",
|
|
"filename": "kuryr_kubernetes/tests/unit/controller/handlers/test_loadbalancer.py",
|
|
"patchSetId": 20
|
|
},
|
|
"lineNbr": 834,
|
|
"author": {
|
|
"id": 27032
|
|
},
|
|
"writtenOn": "2021-07-19T08:55:51Z",
|
|
"side": 1,
|
|
"message": "You can a fixture Kuryr provides to access the octavia client and consequently octavia resources\nhttps://github.com/openstack/kuryr-kubernetes/blob/master/kuryr_kubernetes/tests/unit/controller/drivers/test_lbaasv2.py#L489",
|
|
"revId": "f8e8aba14e6a4eb3364ea9836b4fb1889c4c20b2",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": true
|
|
}
|
|
]
|
|
} |