142 lines
3.7 KiB
Plaintext
142 lines
3.7 KiB
Plaintext
{
|
|
"comments": [
|
|
{
|
|
"key": {
|
|
"uuid": "ff0f0b1f_53e78941",
|
|
"filename": "kuryr_kubernetes/config.py",
|
|
"patchSetId": 3
|
|
},
|
|
"lineNbr": 79,
|
|
"author": {
|
|
"id": 6598
|
|
},
|
|
"writtenOn": "2017-05-22T05:19:31Z",
|
|
"side": 1,
|
|
"message": "Let\u0027s keep the SR-IOV config separate from the common one, part of the SR-IOV specific config",
|
|
"range": {
|
|
"startLine": 72,
|
|
"startChar": 0,
|
|
"endLine": 79,
|
|
"endChar": 1
|
|
},
|
|
"revId": "8aa85199bad16bb34e82c3aee02565a64c537dbd",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "ff0f0b1f_33e2d530",
|
|
"filename": "kuryr_kubernetes/config.py",
|
|
"patchSetId": 3
|
|
},
|
|
"lineNbr": 100,
|
|
"author": {
|
|
"id": 6598
|
|
},
|
|
"writtenOn": "2017-05-22T05:19:31Z",
|
|
"side": 1,
|
|
"message": "ditto",
|
|
"range": {
|
|
"startLine": 96,
|
|
"startChar": 1,
|
|
"endLine": 100,
|
|
"endChar": 20
|
|
},
|
|
"revId": "8aa85199bad16bb34e82c3aee02565a64c537dbd",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "ff0f0b1f_d3ccb9bd",
|
|
"filename": "kuryr_kubernetes/constants.py",
|
|
"patchSetId": 3
|
|
},
|
|
"lineNbr": 31,
|
|
"author": {
|
|
"id": 6598
|
|
},
|
|
"writtenOn": "2017-05-22T05:19:31Z",
|
|
"side": 1,
|
|
"message": "do not think its required as separate annotation",
|
|
"range": {
|
|
"startLine": 31,
|
|
"startChar": 0,
|
|
"endLine": 31,
|
|
"endChar": 65
|
|
},
|
|
"revId": "8aa85199bad16bb34e82c3aee02565a64c537dbd",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "ff0f0b1f_53c0a97b",
|
|
"filename": "kuryr_kubernetes/controller/drivers/sriov.py",
|
|
"patchSetId": 3
|
|
},
|
|
"lineNbr": 38,
|
|
"author": {
|
|
"id": 6598
|
|
},
|
|
"writtenOn": "2017-05-22T05:19:31Z",
|
|
"side": 1,
|
|
"message": "nothing specific to SR-IOV. Should not be here. Please consider utils module.",
|
|
"range": {
|
|
"startLine": 26,
|
|
"startChar": 0,
|
|
"endLine": 38,
|
|
"endChar": 18
|
|
},
|
|
"revId": "8aa85199bad16bb34e82c3aee02565a64c537dbd",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "ff0f0b1f_535549c5",
|
|
"filename": "kuryr_kubernetes/controller/drivers/sriov.py",
|
|
"patchSetId": 3
|
|
},
|
|
"lineNbr": 68,
|
|
"author": {
|
|
"id": 6598
|
|
},
|
|
"writtenOn": "2017-05-22T05:19:31Z",
|
|
"side": 1,
|
|
"message": "you can use tags if special mark is required",
|
|
"range": {
|
|
"startLine": 68,
|
|
"startChar": 52,
|
|
"endLine": 68,
|
|
"endChar": 60
|
|
},
|
|
"revId": "8aa85199bad16bb34e82c3aee02565a64c537dbd",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "ff0f0b1f_736f2d92",
|
|
"filename": "kuryr_kubernetes/controller/handlers/sriov_vif.py",
|
|
"patchSetId": 3
|
|
},
|
|
"lineNbr": 51,
|
|
"author": {
|
|
"id": 6598
|
|
},
|
|
"writtenOn": "2017-05-22T05:19:31Z",
|
|
"side": 1,
|
|
"message": "If the Generic Handler is enabled as well, does it mean you will have to modify it as well to skip the SR-IOV pods?",
|
|
"range": {
|
|
"startLine": 48,
|
|
"startChar": 6,
|
|
"endLine": 51,
|
|
"endChar": 18
|
|
},
|
|
"revId": "8aa85199bad16bb34e82c3aee02565a64c537dbd",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
}
|
|
]
|
|
} |