129 lines
4.5 KiB
Plaintext
129 lines
4.5 KiB
Plaintext
{
|
|
"comments": [
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "d31ba5a5_012d5dd9",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 3
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 13692
|
|
},
|
|
"writtenOn": "2024-03-05T08:06:20Z",
|
|
"side": 1,
|
|
"message": "Docker gate is pinned to the last supported version for docker (1.23), and seems like there is no k8s packages for this version on new repo location. 1.23 is more than 2 years old now, and unsupported by the k8s team. Perhaps it\u0027ll be worth to drop docker support or adopt it to cri-dockerd - which should happen in devstack-plugin-container.",
|
|
"revId": "7acb2be008a93dd8cf1e19f79a31a43452aac806",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "dd4480c4_a10b816f",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 3
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 11600
|
|
},
|
|
"writtenOn": "2024-03-05T09:21:39Z",
|
|
"side": 1,
|
|
"message": "Why don\u0027t we just drop the docker gate then?",
|
|
"parentUuid": "d31ba5a5_012d5dd9",
|
|
"revId": "7acb2be008a93dd8cf1e19f79a31a43452aac806",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "5672b8c9_7e5dfd0f",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 3
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 31857
|
|
},
|
|
"writtenOn": "2024-03-05T10:09:54Z",
|
|
"side": 1,
|
|
"message": "Thanks for your comments.\n\nFor this patch, is it better to drop the docker gate,\n\n\u003e * https://opendev.org/openstack/kuryr-kubernetes/src/branch/master/.zuul.d/project.yaml#L20\n\u003e * https://opendev.org/openstack/kuryr-kubernetes/src/branch/master/.zuul.d/tempest-jobs.yaml#L180-L188\n\nor just change `voting` to false (and drop the docker gate by the another patch)?\n\n\u003e * https://opendev.org/openstack/kuryr-kubernetes/src/branch/master/.zuul.d/tempest-jobs.yaml#L187",
|
|
"parentUuid": "dd4480c4_a10b816f",
|
|
"revId": "7acb2be008a93dd8cf1e19f79a31a43452aac806",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "a5032134_2f59554f",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 3
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 11600
|
|
},
|
|
"writtenOn": "2024-03-05T12:09:26Z",
|
|
"side": 1,
|
|
"message": "Personally I\u0027d just drop it in this commit. Roman, what do you think?",
|
|
"parentUuid": "5672b8c9_7e5dfd0f",
|
|
"revId": "7acb2be008a93dd8cf1e19f79a31a43452aac806",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "1eaa6c5c_167d6134",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 3
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 13692
|
|
},
|
|
"writtenOn": "2024-03-05T13:00:44Z",
|
|
"side": 1,
|
|
"message": "Yup, Let\u0027s do that. Otherwise we will have chicken-egg problem.",
|
|
"parentUuid": "a5032134_2f59554f",
|
|
"revId": "7acb2be008a93dd8cf1e19f79a31a43452aac806",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "fd059d79_73a327d4",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 3
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 31857
|
|
},
|
|
"writtenOn": "2024-03-05T13:05:59Z",
|
|
"side": 1,
|
|
"message": "Thanks! I drop the docker gate in PS4.\nPlease kindly review it.",
|
|
"parentUuid": "1eaa6c5c_167d6134",
|
|
"revId": "7acb2be008a93dd8cf1e19f79a31a43452aac806",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "43fa8856_0975f649",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 3
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 13692
|
|
},
|
|
"writtenOn": "2024-03-05T13:06:40Z",
|
|
"side": 1,
|
|
"message": "Just to be clear - dropping it instead of making non-voting would effect in relief for infra. Non working CI have no added value, and let\u0027s face it - more than two years for transitioning from docker to other CNI is more than enough.",
|
|
"parentUuid": "1eaa6c5c_167d6134",
|
|
"revId": "7acb2be008a93dd8cf1e19f79a31a43452aac806",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
}
|
|
]
|
|
} |