97 lines
2.9 KiB
Plaintext
97 lines
2.9 KiB
Plaintext
{
|
|
"comments": [
|
|
{
|
|
"key": {
|
|
"uuid": "75122776_e8a0d8cf",
|
|
"filename": "kuryr_kubernetes/controller/drivers/utils.py",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 345,
|
|
"author": {
|
|
"id": 23567
|
|
},
|
|
"writtenOn": "2021-06-30T14:43:57Z",
|
|
"side": 1,
|
|
"message": "this should be namespace, right? either you provide a namespace (and only return the CRDs on that namespace) or you don\u0027t provide the namespace and return all the CRDs on all namespaces",
|
|
"range": {
|
|
"startLine": 345,
|
|
"startChar": 31,
|
|
"endLine": 345,
|
|
"endChar": 48
|
|
},
|
|
"revId": "350b8fe806453ef85fecf2eb33dd866357d88d91",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": true
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "0d5e1095_40ad5510",
|
|
"filename": "kuryr_kubernetes/controller/drivers/utils.py",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 345,
|
|
"author": {
|
|
"id": 33240
|
|
},
|
|
"writtenOn": "2021-06-30T14:47:27Z",
|
|
"side": 1,
|
|
"message": "\u003e this should be namespace, right? either you provide a namespace (and only return the CRDs on that namespace) or you don\u0027t provide the namespace and return all the CRDs on all namespaces\n\nOkay got it!",
|
|
"parentUuid": "75122776_e8a0d8cf",
|
|
"range": {
|
|
"startLine": 345,
|
|
"startChar": 31,
|
|
"endLine": 345,
|
|
"endChar": 48
|
|
},
|
|
"revId": "350b8fe806453ef85fecf2eb33dd866357d88d91",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": true
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "0f212e45_afda2003",
|
|
"filename": "kuryr_kubernetes/controller/handlers/loadbalancer.py",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 135,
|
|
"author": {
|
|
"id": 23567
|
|
},
|
|
"writtenOn": "2021-06-30T14:43:57Z",
|
|
"side": 1,
|
|
"message": "this should not be inside this try/except",
|
|
"range": {
|
|
"startLine": 133,
|
|
"startChar": 0,
|
|
"endLine": 135,
|
|
"endChar": 49
|
|
},
|
|
"revId": "350b8fe806453ef85fecf2eb33dd866357d88d91",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": true
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "46aafa0c_74223dcd",
|
|
"filename": "kuryr_kubernetes/controller/handlers/loadbalancer.py",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 147,
|
|
"author": {
|
|
"id": 23567
|
|
},
|
|
"writtenOn": "2021-06-30T15:09:01Z",
|
|
"side": 1,
|
|
"message": "actually, this should be the other way around... you need to check if the loadbalancer on the CRD exist on the list of loadbalanacers on the OpenStack side",
|
|
"range": {
|
|
"startLine": 144,
|
|
"startChar": 0,
|
|
"endLine": 147,
|
|
"endChar": 45
|
|
},
|
|
"revId": "350b8fe806453ef85fecf2eb33dd866357d88d91",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": true
|
|
}
|
|
]
|
|
} |