kuryr-kubernetes/898b549a89d740f41e79b71e0c0eb87457b42396

{
  "comments": [
    {
      "key": {
        "uuid": "7f515b1d_b79d2e0b",
        "filename": "contrib/pools-management/README.rst",
        "patchSetId": 6
      },
      "lineNbr": 253,
      "author": {
        "id": 23630
      },
      "writtenOn": "2017-10-02T09:50:22Z",
      "side": 1,
      "message": "white space",
      "range": {
        "startLine": 253,
        "startChar": 54,
        "endLine": 253,
        "endChar": 55
      },
      "revId": "898b549a89d740f41e79b71e0c0eb87457b42396",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": false
    },
    {
      "key": {
        "uuid": "7f515b1d_7727b6cb",
        "filename": "contrib/pools-management/README.rst",
        "patchSetId": 6
      },
      "lineNbr": 253,
      "author": {
        "id": 23567
      },
      "writtenOn": "2017-10-02T10:40:56Z",
      "side": 1,
      "message": "Done",
      "parentUuid": "7f515b1d_b79d2e0b",
      "range": {
        "startLine": 253,
        "startChar": 54,
        "endLine": 253,
        "endChar": 55
      },
      "revId": "898b549a89d740f41e79b71e0c0eb87457b42396",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": false
    },
    {
      "key": {
        "uuid": "7f515b1d_57015a37",
        "filename": "kuryr_kubernetes/controller/managers/pool.py",
        "patchSetId": 6
      },
      "lineNbr": 207,
      "author": {
        "id": 23630
      },
      "writtenOn": "2017-10-02T09:50:22Z",
      "side": 1,
      "message": "according to this:\n\n    def show_pool(self, pool_key):\n        return self._available_ports_pools.get(pool_key)\n\npool can be None --\u003e exception will be thrown",
      "range": {
        "startLine": 207,
        "startChar": 23,
        "endLine": 207,
        "endChar": 27
      },
      "revId": "898b549a89d740f41e79b71e0c0eb87457b42396",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": false
    },
    {
      "key": {
        "uuid": "7f515b1d_a9527211",
        "filename": "kuryr_kubernetes/controller/managers/pool.py",
        "patchSetId": 6
      },
      "lineNbr": 207,
      "author": {
        "id": 23567
      },
      "writtenOn": "2017-10-02T10:40:56Z",
      "side": 1,
      "message": "Done",
      "parentUuid": "7f515b1d_57015a37",
      "range": {
        "startLine": 207,
        "startChar": 23,
        "endLine": 207,
        "endChar": 27
      },
      "revId": "898b549a89d740f41e79b71e0c0eb87457b42396",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": false
    },
    {
      "key": {
        "uuid": "7f515b1d_576a7a19",
        "filename": "kuryr_kubernetes/tests/unit/controller/managers/test_pool.py",
        "patchSetId": 6
      },
      "lineNbr": 86,
      "author": {
        "id": 23630
      },
      "writtenOn": "2017-10-02T09:50:22Z",
      "side": 1,
      "message": "reindent like this:\n\n        with (mock.patch.object(self._req_handler.rfile, \u0027read\u0027) as m_read,\n                mock.patch.object(self._req_handler, \u0027_list_pools\u0027) as m_list,\n                mock.patch.object(self._req_handler, \u0027_show_pool\u0027) as m_show):",
      "range": {
        "startLine": 82,
        "startChar": 0,
        "endLine": 86,
        "endChar": 54
      },
      "revId": "898b549a89d740f41e79b71e0c0eb87457b42396",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": false
    },
    {
      "key": {
        "uuid": "7f515b1d_c9080e93",
        "filename": "kuryr_kubernetes/tests/unit/controller/managers/test_pool.py",
        "patchSetId": 6
      },
      "lineNbr": 86,
      "author": {
        "id": 23567
      },
      "writtenOn": "2017-10-02T10:40:56Z",
      "side": 1,
      "message": "this does not fit into pep8 line length, and with cannot be split with the \"(\". At least not in that way.",
      "parentUuid": "7f515b1d_576a7a19",
      "range": {
        "startLine": 82,
        "startChar": 0,
        "endLine": 86,
        "endChar": 54
      },
      "revId": "898b549a89d740f41e79b71e0c0eb87457b42396",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": false
    },
    {
      "key": {
        "uuid": "7f515b1d_f764c64b",
        "filename": "kuryr_kubernetes/tests/unit/controller/managers/test_pool.py",
        "patchSetId": 6
      },
      "lineNbr": 100,
      "author": {
        "id": 23630
      },
      "writtenOn": "2017-10-02T09:50:22Z",
      "side": 1,
      "message": "same with this one",
      "range": {
        "startLine": 95,
        "startChar": 0,
        "endLine": 100,
        "endChar": 54
      },
      "revId": "898b549a89d740f41e79b71e0c0eb87457b42396",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": false
    }
  ]
}