From 42b0c306a05d08f0ecc52a41fb40acddbdb7bb75 Mon Sep 17 00:00:00 2001 From: SijieYang Date: Mon, 4 Jun 2018 18:47:32 +0800 Subject: [PATCH] modify the kuryr workflow document In the document, it shows that when user input commands like "sudo docker run --net=foo -itd --name=container1 busybox", '/IpamDriver.RequestAddress' will get a POST call which the 'options' is empty, just like this: { "Address": "", "PoolID": "941f790073c3a2c70099ea527ee3a6205e037e84749f2c6e8a5287d9c62fd376", "Options": {}, } but I have checked the workflow, and I found it's not true. The Options will be non-empty, and it will be like "com.docker.network.endpoint.macaddress": "08:22:e0:a8:7d:db". Fixes: Bug 1774977 Change-Id: Ia4632fb376471893de71b57b49ca0241cf0f60c2 --- doc/source/devref/libnetwork_remote_driver_design.rst | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/doc/source/devref/libnetwork_remote_driver_design.rst b/doc/source/devref/libnetwork_remote_driver_design.rst index b1d270fb..8382ac6a 100644 --- a/doc/source/devref/libnetwork_remote_driver_design.rst +++ b/doc/source/devref/libnetwork_remote_driver_design.rst @@ -140,7 +140,7 @@ Libnetwork User Workflow (with Kuryr as remote network driver) - Host Networking { "Address": "", "PoolID": "941f790073c3a2c70099ea527ee3a6205e037e84749f2c6e8a5287d9c62fd376", - "Options": {}, + "Options": {"com.docker.network.endpoint.macaddress": "08:22:e0:a8:7d:db"}, } The IPAM driver Kuryr sends a port creation request to neutron and returns the following response with neutron provided ip address:: @@ -158,7 +158,7 @@ Libnetwork User Workflow (with Kuryr as remote network driver) - Host Networking "NetworkID": "286eddb51ebca09339cb17aaec05e48ffe60659ced6f3fc41b020b0eb506d364", "Interface": { "AddressIPv6": "", - "MacAddress": "", + "MacAddress": "08:22:e0:a8:7d:db", "Address": "10.0.0.2/24" }, "Options": { @@ -185,7 +185,7 @@ Libnetwork User Workflow (with Kuryr as remote network driver) - Host Networking (https://github.com/docker/libnetwork/blob/master/docs/remote.md#create-endpoint):: { - "Interface": {"MacAddress": "08:22:e0:a8:7d:db"} + "Interface": {"MacAddress": ""} }