openstack
/
kuryr-libnetwork
Code Issues Proposed changes

Remove unnecessary code 

The population of mac address on creating port is unnecessary
because the mac address will be updated on creating endpoint.

Related-Bug: #1800375
Change-Id: Iee23b16fd4905e3ce21ff8a463253641dc191541
This commit is contained in:
Hongbin Lu 2018-10-28 21:13:59 +00:00
parent 755e7c0c48
commit f0e48ebaa0
2 changed files with 0 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
kuryr_libnetwork/controllers.py
View File

@ -1704,8 +1704,6 @@ def ipam_request_address():
'admin_state_up': True,
'network_id': neutron_network_id,
}
if req_mac_address:
port['mac_address'] = req_mac_address
fixed_ips = port['fixed_ips'] = []
fixed_ip = {'subnet_id': subnet['id']}
filtered_ports = []

4
kuryr_libnetwork/tests/unit/test_kuryr_ipam.py
View File

@ -668,7 +668,6 @@ class TestKuryrIpam(base.TestKuryrBase):
'name': const.KURYR_UNBOUND_PORT,
'admin_state_up': True,
'network_id': neutron_network_id,
'mac_address': fake_mac_address,
}
fixed_ips = port_request['fixed_ips'] = []
fixed_ip = {'subnet_id': subnet_v4_id}
@ -776,7 +775,6 @@ class TestKuryrIpam(base.TestKuryrBase):
'name': const.KURYR_UNBOUND_PORT,
'admin_state_up': True,
'network_id': neutron_network_id,
'mac_address': fake_mac_address,
}
fixed_ips = port_request['fixed_ips'] = []
fixed_ip = {'subnet_id': subnet_v4_id,
@ -1104,7 +1102,6 @@ class TestKuryrIpam(base.TestKuryrBase):
'name': const.KURYR_UNBOUND_PORT,
'admin_state_up': True,
'network_id': neutron_network_id,
'mac_address': fake_mac_address,
}
port_request['fixed_ips'] = []
fixed_ip = {'subnet_id': neutron_subnet_v4_id}
@ -1262,7 +1259,6 @@ class TestKuryrIpam(base.TestKuryrBase):
'name': const.KURYR_UNBOUND_PORT,
'admin_state_up': True,
'network_id': neutron_network_id,
'mac_address': fake_mac_address,
}
port_request['fixed_ips'] = []
fixed_ip = {'subnet_id': neutron_subnet_v4_id}