openstack
/
kuryr
Code Issues Proposed changes

Add more ut for kuryr/lib/utils.py 

Only have two UT for utils.py now, I add UT for most of the rest
functions in utils.py ,

Change-Id: Ie1c3aeaf02d0a1c2f3fbe3fd6913678afa1618cb
This commit is contained in:
Liping Mao 2016-07-23 22:23:16 +08:00
parent 4287cf791b
commit c6f277adcf
1 changed files with 63 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

65
kuryr/tests/unit/test_utils.py
View File

@ -10,9 +10,10 @@
# License for the specific language governing permissions and limitations
# under the License.
import uuid
import ddt
import mock
import socket
import uuid
from oslo_config import cfg
@ -24,6 +25,10 @@ from kuryr.tests.unit import base
@ddt.ddt
class TestKuryrUtils(base.TestCase):
"""Unit tests for utilities."""
def setUp(self):
super(TestKuryrUtils, self).setUp()
self.fake_url = 'http://127.0.0.1:9696'
self.fake_auth_url = 'http://127.0.0.1:35357/v2.0'
def test_get_veth_pair_names(self):
fake_neutron_port_id = str(uuid.uuid4())
@ -48,3 +53,59 @@ class TestKuryrUtils(base.TestCase):
name_prefix = cfg.CONF.subnetpool_name_prefix
self.assertIn(name_prefix, generated_neutron_subnetpool_name)
self.assertIn(fake_subnet_cidr, generated_neutron_subnetpool_name)
@mock.patch('neutronclient.neutron.client.Client')
def test_get_neutron_client_simple(self, mock_client):
fake_token = str(uuid.uuid4())
utils.get_neutron_client_simple(url=self.fake_url,
auth_url=self.fake_auth_url, token=fake_token)
mock_client.assert_called_once_with('2.0',
endpoint_url=self.fake_url, token=fake_token)
@mock.patch('neutronclient.v2_0.client.Client')
def test_get_neutron_client(self, mock_client):
fake_username = 'fake_user'
fake_tenant_name = 'fake_tenant_name'
fake_password = 'fake_password'
fake_ca_cert = None
fake_insecure = False
fake_timeout = 60
utils.get_neutron_client(url=self.fake_url, username=fake_username,
tenant_name=fake_tenant_name, password=fake_password,
auth_url=self.fake_auth_url, ca_cert=fake_ca_cert,
insecure=fake_insecure, timeout=fake_timeout)
mock_client.assert_called_once_with(endpoint_url=self.fake_url,
timeout=fake_timeout, username=fake_username,
tenant_name=fake_tenant_name, password=fake_password,
auth_url=self.fake_auth_url, ca_cert=fake_ca_cert,
insecure=fake_insecure)
@mock.patch.object(socket, 'gethostname', return_value='fake_hostname')
def test_get_hostname(self, mock_get_hostname):
self.assertEqual('fake_hostname', utils.get_hostname())
mock_get_hostname.assert_called_once()
def test_get_dict_format_fixed_ips_from_kv_format(self):
fake_fixed_ips_kv_format = \
['subnet_id=5083bda8-1b7c-4625-97f3-1d4c33bfeea8',
'ip_address=192.168.1.2',
'subnet_id=6607a230-f3eb-4937-b09f-9dd659211139',
'ip_address=fdfa:8456:1afa:0:f816:3eff:fe67:885e']
expected_dict_form = \
[{'subnet_id': '5083bda8-1b7c-4625-97f3-1d4c33bfeea8',
'ip_address': '192.168.1.2'},
{'subnet_id': '6607a230-f3eb-4937-b09f-9dd659211139',
'ip_address': 'fdfa:8456:1afa:0:f816:3eff:fe67:885e'}]
fixed_ips = utils.get_dict_format_fixed_ips_from_kv_format(
fake_fixed_ips_kv_format)
self.assertEqual(expected_dict_form, fixed_ips)
def test_string_mappings(self):
fake_mapping_list = {'fake_key': 'fake_value'}
fake_result = '"{\'fake_key\': \'fake_value\'}"'
self.assertEqual(fake_result, utils.string_mappings(fake_mapping_list))
def test_get_random_string(self):
fake_string_len = 20
self.assertEqual(fake_string_len,
len(utils.get_random_string(fake_string_len)))