openstack/kuryr
Code Issues Proposed changes

Fix H405 violations

Browse Source 
There are H405 violation codes.
We need to fix the code for avoiding more violations.

Change-Id: I8084ae4b91961a302b52dc66c3d342be1b753ecc
Closes-Bug: #1521899
This commit is contained in:
Kenji Yasui 2015-12-07 06:53:36 +00:00
parent 4bd27cce7d
commit de257bf5fc
4 changed files with 4 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
kuryr/controllers.py
View File

@ -54,8 +54,7 @@ else:
def check_for_neutron_ext_support(): def check_for_neutron_ext_support():
"""Validates for mandatory extension support availability in neutron. """Validates for mandatory extension support availability in neutron."""
"""
try: try:
app.neutron.show_extension(MANDATORY_NEUTRON_EXTENSION) app.neutron.show_extension(MANDATORY_NEUTRON_EXTENSION)
except n_exceptions.NeutronClientException as e: except n_exceptions.NeutronClientException as e:

3
kuryr/tests/test_join.py
View File

@ -28,8 +28,7 @@ from kuryr import utils
@ddt.ddt @ddt.ddt
class TestKuryrJoinFailures(base.TestKuryrFailures): class TestKuryrJoinFailures(base.TestKuryrFailures):
"""Unit tests for the failures for binding a Neutron port to an interface. """Unit tests for the failures for binding a Neutron port."""
"""
def _invoke_join_request(self, docker_network_id, def _invoke_join_request(self, docker_network_id,
docker_endpoint_id, container_id): docker_endpoint_id, container_id):
data = { data = {

3
kuryr/tests/test_leave.py
View File

@ -28,8 +28,7 @@ from kuryr import utils
@ddt.ddt @ddt.ddt
class TestKuryrLeaveFailures(base.TestKuryrFailures): class TestKuryrLeaveFailures(base.TestKuryrFailures):
"""Unit tests for the failures for unbinding a Neutron port. """Unit tests for the failures for unbinding a Neutron port."""
"""
def _invoke_leave_request(self, docker_network_id, def _invoke_leave_request(self, docker_network_id,
docker_endpoint_id): docker_endpoint_id):
data = { data = {

4
tox.ini
View File

@ -37,10 +37,8 @@ commands = python setup.py build_sphinx
# H305 imports not grouped correctly # H305 imports not grouped correctly
# H307 like imports should be grouped together # H307 like imports should be grouped together
# H402 one line docstring needs punctuation # H402 one line docstring needs punctuation
# H404 multi line docstring should start with a summary
# H405 multi line docstring summary not separated with an empty line
# H904 Wrap long lines in parentheses instead of a backslash # H904 Wrap long lines in parentheses instead of a backslash
ignore = E125,E126,E128,E129,E265,H301,H305,H307,H402,H404,H405,H904 ignore = E125,E126,E128,E129,E265,H301,H305,H307,H402,H904
show-source = true show-source = true
# TODO(dougw) neutron/tests/unit/vmware exclusion is a temporary services split hack # TODO(dougw) neutron/tests/unit/vmware exclusion is a temporary services split hack