From a5f57d1eff40971b71e55953c9d50fec3a57be41 Mon Sep 17 00:00:00 2001 From: Tim Burke Date: Tue, 23 Sep 2025 14:19:58 -0700 Subject: [PATCH] Run helgrind (and rename memcheck target) Change-Id: Iab0f8cc4779008b8e6244e73aab9d133de056bbf Signed-off-by: Tim Burke --- .zuul.yaml | 18 ++++++++++++++++-- Makefile.am | 20 +++++++++++++------- 2 files changed, 29 insertions(+), 9 deletions(-) diff --git a/.zuul.yaml b/.zuul.yaml index 48d784b..e01651f 100644 --- a/.zuul.yaml +++ b/.zuul.yaml @@ -10,13 +10,25 @@ name: liberasurecode-unittests-memcheck parent: liberasurecode-unittests description: | - Build and run valgrind-test for liberasurecode. + Build and run memcheck-test for liberasurecode. dependencies: # Don't bother doing the more-intensive valgrind checks # if tests aren't even passing - liberasurecode-unittests vars: - make_target: valgrind-test + make_target: memcheck-test + +- job: + name: liberasurecode-unittests-helgrind + parent: liberasurecode-unittests + description: | + Build and run helgrind-test for liberasurecode. + dependencies: + # Don't bother doing the more-intensive valgrind checks + # if tests aren't even passing + - liberasurecode-unittests + vars: + make_target: helgrind-test - job: name: liberasurecode-check-symbols @@ -57,6 +69,7 @@ - liberasurecode-check-symbols - liberasurecode-unittests - liberasurecode-unittests-memcheck + - liberasurecode-unittests-helgrind - liberasurecode-unittests-centos-9-stream - liberasurecode-unittests-centos-9-stream-fips check-arm64: @@ -67,5 +80,6 @@ - liberasurecode-check-symbols - liberasurecode-unittests - liberasurecode-unittests-memcheck + - liberasurecode-unittests-helgrind - liberasurecode-unittests-centos-9-stream - liberasurecode-unittests-centos-9-stream-fips diff --git a/Makefile.am b/Makefile.am index 087f13b..88e46c2 100644 --- a/Makefile.am +++ b/Makefile.am @@ -53,16 +53,22 @@ test: check @./test/libec_slap LIBTOOL_COMMAND = $(LIBTOOL) --mode execute -VALGRIND_EXEC_COMMAND = $(LIBTOOL_COMMAND) valgrind --tool=memcheck \ +MEMCHECK_EXEC_COMMAND = $(LIBTOOL_COMMAND) valgrind --tool=memcheck \ --error-exitcode=1 --leak-check=yes --track-fds=yes \ --malloc-fill=A5 --free-fill=DE --fullpath-after=. --trace-children=yes -valgrind-test: check - @$(VALGRIND_EXEC_COMMAND) ./test/alg_sig_test - @$(VALGRIND_EXEC_COMMAND) ./test/liberasurecode_test - @$(VALGRIND_EXEC_COMMAND) ./test/liberasurecode_threaded_test - @$(VALGRIND_EXEC_COMMAND) ./test/test_xor_hd_code - @$(VALGRIND_EXEC_COMMAND) ./test/libec_slap +memcheck-test: check + @$(MEMCHECK_EXEC_COMMAND) ./test/alg_sig_test + @$(MEMCHECK_EXEC_COMMAND) ./test/liberasurecode_test + @$(MEMCHECK_EXEC_COMMAND) ./test/liberasurecode_threaded_test + @$(MEMCHECK_EXEC_COMMAND) ./test/test_xor_hd_code + @$(MEMCHECK_EXEC_COMMAND) ./test/libec_slap + +HELGRIND_EXEC_COMMAND = $(LIBTOOL_COMMAND) valgrind --tool=helgrind \ + --error-exitcode=1 --fullpath-after=. --trace-children=yes + +helgrind-test: check + @$(HELGRIND_EXEC_COMMAND) ./test/liberasurecode_threaded_test check-symbols: all @./check-symbols.sh check