openstack
/
magnum
Code Issues Proposed changes

register the config generator default hook with the right name 

No config generator hooks should ever be registered with a name that
belongs to another project. In this case, using oslo.middleware.cors
means that *every other project* that loads the middleware gets this
application's defaults when the generator is run on a system with
everything installed (such as a dev box with devstack). Use the name
of the app instead, to ensure that the defaults are only set when this
app's sample config and documentation are being generated.

Change-Id: I6a8c7d44b9db9325003ff2fdb667b0ced7739e96
Signed-off-by: Doug Hellmann <doug@doughellmann.com>
This commit is contained in:
Doug Hellmann 2016-03-11 15:29:05 -05:00
parent 7b1c040716
commit 165b5cf30e
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
setup.cfg
View File

@ -53,7 +53,7 @@ oslo.config.opts =
magnum = magnum.opts:list_opts
oslo.config.opts.defaults =
oslo.middleware.cors = magnum.common.config:set_cors_middleware_defaults
magnum = magnum.common.config:set_cors_middleware_defaults
magnum.template_definitions =
magnum_vm_atomic_k8s = magnum.conductor.template_definition:AtomicK8sTemplateDefinition