Update patch set 12

Patch Set 12:

(1 comment)

Patch-set: 12
This commit is contained in:
Gerrit User 6484 2021-04-23 02:05:23 +00:00 committed by Gerrit Code Review
parent 3e3cff7bd0
commit 2c1dae3c38
1 changed files with 18 additions and 0 deletions

View File

@ -16,6 +16,24 @@
"revId": "0a92b33b61ec519d1afbbed6217cf225a02927a6",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": true
},
{
"key": {
"uuid": "ccc74f49_554dd87b",
"filename": "magnum/drivers/common/templates/kubernetes/fragments/upgrade-kubernetes.sh",
"patchSetId": 12
},
"lineNbr": 6,
"author": {
"id": 6484
},
"writtenOn": "2021-04-23T02:05:23Z",
"side": 1,
"message": "Hi Krzysztof, thanks for your comments. Unfortunately, we cannot do that. Because when this piece of code being run, the node has already been rebuilt. So we cannot drain the node here 😞\n\nI\u0027m thinking to leverage the pre-create or pre-update hook of Heat to \u0027pause\u0027 the process, so that we can get a chance to drain the node, but that probably means we have to use something running inside the cluster to trigger the drain action and then signal Heat to continue. Please let me know if you have a better idea. Cheers.",
"parentUuid": "433d4607_50a9d3ae",
"revId": "0a92b33b61ec519d1afbbed6217cf225a02927a6",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": true
}
]
}