openstack
/
magnum
Code Issues Proposed changes

Avoid to create $SCREEN_LOGDIR 

It is possible not to give SCREEN_LOGDIR variable in devstack.
And also, SCREEN_LOGDIR is creating in stack.sh itself [1].
So we can remove our code which is creating SCREEN_LOGDIR.
This code breaks stack.sh process if user doesn't give this
variable.

[1]: 2688eedc51/stack.sh (L454)

Change-Id: I5c6ce81a97635b60fc1633397a24f93dc590fad6
Closes-Bug: #1548197
This commit is contained in:
OTSUKA, Yuanying 2016-02-22 15:31:57 +09:00
parent 39288ea1dd
commit 32cfd6c2cc
1 changed files with 1 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
devstack/plugin.sh
View File

@ -9,10 +9,7 @@ source $DEST/magnum/devstack/lib/magnum
(set -o posix; set)
if is_service_enabled m-api m-cond; then
if [[ "$1" == "stack" && "$2" == "pre-install" ]]; then
echo_summary "Before Installing magnum"
mkdir -p $SCREEN_LOGDIR
elif [[ "$1" == "stack" && "$2" == "install" ]]; then
if [[ "$1" == "stack" && "$2" == "install" ]]; then
echo_summary "Installing magnum"
install_magnum