openstack
/
magnum
Code Issues Proposed changes

Update patch set 12 

Patch Set 12:

(1 comment)

Patch-set: 12
CC: Gerrit User 16036 <16036@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
This commit is contained in:
Gerrit User 16036 2021-04-21 17:06:35 +00:00 committed by Gerrit Code Review
parent dd6dbacf4b
commit 3e3cff7bd0
1 changed files with 21 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
0a92b33b61ec519d1afbbed6217cf225a02927a6 Normal file
View File

@ -0,0 +1,21 @@
{
"comments": [
{
"key": {
"uuid": "433d4607_50a9d3ae",
"filename": "magnum/drivers/common/templates/kubernetes/fragments/upgrade-kubernetes.sh",
"patchSetId": 12
},
"lineNbr": 6,
"author": {
"id": 16036
},
"writtenOn": "2021-04-21T17:06:35Z",
"side": 1,
"message": "Wouldn\u0027t it make sense to drain the node at this point, if we know for the fact that it\u0027s about to be rebuilt? If for whatever reason it\u0027s not a good place to do that, is there some better way of ensuring that the node is drained before we rebuild it?",
"revId": "0a92b33b61ec519d1afbbed6217cf225a02927a6",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": true
}
]
}