From 4eb503d8e1476b24b44fbce0fa54d955a38b12b4 Mon Sep 17 00:00:00 2001 From: "OTSUKA, Yuanying" Date: Tue, 1 Sep 2015 14:47:29 +0900 Subject: [PATCH] Introduce unit test for genconfig We don't have unit test for genconfig, so sometimes this feature is broken because of missing options or moving options. This patch adds checking test for config parameters. Change-Id: I67a44ef02704f66740a6bda2b6502b6b1636a08b Closes-Bug: #1490825 --- magnum/tests/conf_fixture.py | 2 +- magnum/tests/unit/test_opts.py | 28 ++++++++++++++++++++++++++++ 2 files changed, 29 insertions(+), 1 deletion(-) create mode 100644 magnum/tests/unit/test_opts.py diff --git a/magnum/tests/conf_fixture.py b/magnum/tests/conf_fixture.py index 9227d6a026..bfa2304dbe 100644 --- a/magnum/tests/conf_fixture.py +++ b/magnum/tests/conf_fixture.py @@ -20,7 +20,7 @@ from oslo_log import log from magnum.common import config -cfg.CONF.register_opt(cfg.StrOpt('host', default='localhost', help='host')) +cfg.CONF.import_opt('host', 'magnum.common.service') log.register_options(cfg.CONF) diff --git a/magnum/tests/unit/test_opts.py b/magnum/tests/unit/test_opts.py new file mode 100644 index 0000000000..115631ca45 --- /dev/null +++ b/magnum/tests/unit/test_opts.py @@ -0,0 +1,28 @@ +# Copyright 2015 NEC Corporation. All rights reserved. +# +# Licensed under the Apache License, Version 2.0 (the "License"); you may +# not use this file except in compliance with the License. You may obtain +# a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT +# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the +# License for the specific language governing permissions and limitations +# under the License. + +from oslo_config import cfg +import six + +from magnum import opts +from magnum.tests import base + + +class OptsTestCase(base.BaseTestCase): + + def test_list_opts(self): + for group_name, opt_list in opts.list_opts(): + self.assertIsInstance(group_name, six.string_types) + for opt in opt_list: + self.assertIsInstance(opt, cfg.Opt)