From 514dc58906bebc9eeb9d0f80cc533067a14caf62 Mon Sep 17 00:00:00 2001
From: "huang.huayong" <huang.huayong2@zte.com.cn>
Date: Tue, 19 Jul 2016 14:10:41 +0800
Subject: [PATCH] add hacking for assertIsNotNone

add hacking assertIsNotNone(A),errors = [(1, 0, "M319")]

Change-Id: I08beb689a16f212de4413bc1b888f6dbe4c183c3
---
 HACKING.rst                       |  2 ++
 magnum/hacking/checks.py          | 18 ++++++++++++++++++
 magnum/tests/unit/test_hacking.py | 13 +++++++++++++
 3 files changed, 33 insertions(+)

diff --git a/HACKING.rst b/HACKING.rst
index 9a88b7900d..f9bd5068fb 100644
--- a/HACKING.rst
+++ b/HACKING.rst
@@ -16,6 +16,8 @@ Magnum Specific Commandments
   assertIsInstance(A, B).
 - [M318] Change assertEqual(A, None) or assertEqual(None, A) by optimal assert
   like assertIsNone(A)
+- [M319] Change assertNotEqual(A, None) or assertNotEqual(None, A)
+  by optimal assert like assertIsNotNone(A)
 - [M322] Method's default argument shouldn't be mutable.
 - [M323] Change assertEqual(True, A) or assertEqual(False, A) by optimal assert
   like assertTrue(A) or assertFalse(A)
diff --git a/magnum/hacking/checks.py b/magnum/hacking/checks.py
index 8238a6e797..c27524d5a0 100644
--- a/magnum/hacking/checks.py
+++ b/magnum/hacking/checks.py
@@ -39,6 +39,10 @@ assert_equal_end_with_none_re = re.compile(
     r"(.)*assertEqual\((\w|\.|\'|\"|\[|\])+, None\)")
 assert_equal_start_with_none_re = re.compile(
     r"(.)*assertEqual\(None, (\w|\.|\'|\"|\[|\])+\)")
+assert_not_equal_end_with_none_re = re.compile(
+    r"(.)*assertNotEqual\((\w|\.|\'|\"|\[|\])+, None\)")
+assert_not_equal_start_with_none_re = re.compile(
+    r"(.)*assertNotEqual\(None, (\w|\.|\'|\"|\[|\])+\)")
 assert_equal_with_true_re = re.compile(
     r"assertEqual\(True,")
 assert_equal_with_false_re = re.compile(
@@ -66,6 +70,19 @@ def assert_equal_none(logical_line):
         yield (0, msg)
 
 
+def assert_not_equal_none(logical_line):
+    """Check for assertNotEqual(A, None) or assertNotEqual(None, A) sentences
+
+    M319
+    """
+    msg = ("M319: assertNotEqual(A, None) or assertNotEqual(None, A) "
+           "sentences not allowed")
+    res = (assert_not_equal_start_with_none_re.match(logical_line) or
+           assert_not_equal_end_with_none_re.match(logical_line))
+    if res:
+        yield (0, msg)
+
+
 def no_mutable_default_args(logical_line):
     msg = "M322: Method's default argument shouldn't be mutable!"
     if mutable_default_args.match(logical_line):
@@ -147,6 +164,7 @@ def dict_constructor_with_list_copy(logical_line):
 def factory(register):
     register(no_mutable_default_args)
     register(assert_equal_none)
+    register(assert_not_equal_none)
     register(assert_equal_true_or_false)
     register(assert_equal_not_none)
     register(assert_true_isinstance)
diff --git a/magnum/tests/unit/test_hacking.py b/magnum/tests/unit/test_hacking.py
index 76eb07b9b9..991c2e030f 100644
--- a/magnum/tests/unit/test_hacking.py
+++ b/magnum/tests/unit/test_hacking.py
@@ -130,6 +130,19 @@ class HackingTestCase(base.TestCase):
         code = "self.assertIsNone()"
         self._assert_has_no_errors(code, check)
 
+    def test_assert_not_equal_none(self):
+        errors = [(1, 0, "M319")]
+        check = checks.assert_not_equal_none
+
+        code = "self.assertNotEqual(A, None)"
+        self._assert_has_errors(code, check, errors)
+
+        code = "self.assertNotEqual(None, A)"
+        self._assert_has_errors(code, check, errors)
+
+        code = "self.assertIsNotNone()"
+        self._assert_has_no_errors(code, check)
+
     def test_assert_equal_true_or_false(self):
         errors = [(1, 0, "M323")]
         check = checks.assert_equal_true_or_false