openstack
/
magnum
Code Issues Proposed changes

Update patch set 21 

Patch Set 21:

(16 comments)

Patch-set: 21
Attention: {"person_ident":"Gerrit User 8556 \u003c8556@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_12404\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 12404 \u003c12404@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_12404\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 8064 \u003c8064@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_12404\u003e replied on the change"}
This commit is contained in:
Gerrit User 12404 2023-05-31 18:16:46 +00:00 committed by Gerrit Code Review
parent 7914c97dce
commit 56226e444d
2 changed files with 378 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

72
28172e91965956b114c62d6642f4ae0436b30e81
View File

@ -40,6 +40,30 @@
"revId": "28172e91965956b114c62d6642f4ae0436b30e81",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "15ed0cc8_341e9273",
"filename": "magnum/common/policies/base.py",
"patchSetId": 20
},
"lineNbr": 17,
"author": {
"id": 12404
},
"writtenOn": "2023-05-31T18:16:46Z",
"side": 1,
"message": "sure",
"parentUuid": "7e53759a_5cda9e8f",
"range": {
"startLine": 17,
"startChar": 0,
"endLine": 17,
"endChar": 10
},
"revId": "28172e91965956b114c62d6642f4ae0436b30e81",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -63,6 +87,30 @@
"revId": "28172e91965956b114c62d6642f4ae0436b30e81",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "c73f7781_0572f279",
"filename": "magnum/common/policies/base.py",
"patchSetId": 20
},
"lineNbr": 103,
"author": {
"id": 12404
},
"writtenOn": "2023-05-31T18:16:46Z",
"side": 1,
"message": "Done",
"parentUuid": "3e740be4_cc6ad2cc",
"range": {
"startLine": 103,
"startChar": 18,
"endLine": 103,
"endChar": 33
},
"revId": "28172e91965956b114c62d6642f4ae0436b30e81",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -85,6 +133,30 @@
},
"revId": "28172e91965956b114c62d6642f4ae0436b30e81",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "21e3f4e2_d3128e0c",
"filename": "magnum/common/policies/base.py",
"patchSetId": 20
},
"lineNbr": 143,
"author": {
"id": 12404
},
"writtenOn": "2023-05-31T18:16:46Z",
"side": 1,
"message": "Done",
"parentUuid": "146b38cb_9ad6a105",
"range": {
"startLine": 142,
"startChar": 36,
"endLine": 143,
"endChar": 26
},
"revId": "28172e91965956b114c62d6642f4ae0436b30e81",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}

306
4bae8265d8d62142de6b52e8a156f6ab3700e9c8
View File

@ -51,6 +51,24 @@
"revId": "4bae8265d8d62142de6b52e8a156f6ab3700e9c8",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "813bef3f_47e4d680",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 21
},
"lineNbr": 0,
"author": {
"id": 12404
},
"writtenOn": "2023-05-31T18:16:46Z",
"side": 1,
"message": "For the implied roles (project_reader and project_member), those are not actual function but just enforce policy to give specific roles more meaningful place.",
"parentUuid": "390a11a2_fcff39bf",
"revId": "4bae8265d8d62142de6b52e8a156f6ab3700e9c8",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -98,6 +116,30 @@
"revId": "4bae8265d8d62142de6b52e8a156f6ab3700e9c8",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "5e84d88f_744d8bb7",
"filename": "devstack/lib/magnum",
"patchSetId": 21
},
"lineNbr": 156,
"author": {
"id": 12404
},
"writtenOn": "2023-05-31T18:16:46Z",
"side": 1,
"message": "yes, we do have a job for that magnum-tempest-plugin-tests-api-rbac which I defined here https://review.opendev.org/c/openstack/magnum-tempest-plugin/+/875322/42/.zuul.yaml#36\n\nAnd added to magnum here https://review.opendev.org/c/openstack/magnum/+/876823\n\nIf we like to have put this job added before we enable it, I can understand. But it is not possible to put it in this patch. as tempest plugin will fail if I\u0027m not wrong. I will add new patch before https://review.opendev.org/c/openstack/magnum/+/876823 so the enablement and adding test can be separate discussion.",
"parentUuid": "4a09757c_1feacc6f",
"range": {
"startLine": 156,
"startChar": 11,
"endLine": 156,
"endChar": 32
},
"revId": "4bae8265d8d62142de6b52e8a156f6ab3700e9c8",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -121,6 +163,30 @@
"revId": "4bae8265d8d62142de6b52e8a156f6ab3700e9c8",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "06101c1a_b8a03fdd",
"filename": "magnum/common/policies/base.py",
"patchSetId": 21
},
"lineNbr": 36,
"author": {
"id": 12404
},
"writtenOn": "2023-05-31T18:16:46Z",
"side": 1,
"message": "Done",
"parentUuid": "81de5d57_0a5347cc",
"range": {
"startLine": 35,
"startChar": 0,
"endLine": 36,
"endChar": 41
},
"revId": "4bae8265d8d62142de6b52e8a156f6ab3700e9c8",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -144,6 +210,30 @@
"revId": "4bae8265d8d62142de6b52e8a156f6ab3700e9c8",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "e3c1f770_de44af4e",
"filename": "magnum/common/policies/base.py",
"patchSetId": 21
},
"lineNbr": 44,
"author": {
"id": 12404
},
"writtenOn": "2023-05-31T18:16:46Z",
"side": 1,
"message": "probably removed as bay was dropped.",
"parentUuid": "885daf18_5bd728a9",
"range": {
"startLine": 43,
"startChar": 0,
"endLine": 44,
"endChar": 48
},
"revId": "4bae8265d8d62142de6b52e8a156f6ab3700e9c8",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -167,6 +257,30 @@
"revId": "4bae8265d8d62142de6b52e8a156f6ab3700e9c8",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "2215e6d5_45b44de8",
"filename": "magnum/common/policies/base.py",
"patchSetId": 21
},
"lineNbr": 64,
"author": {
"id": 12404
},
"writtenOn": "2023-05-31T18:16:46Z",
"side": 1,
"message": "Done",
"parentUuid": "9dc1e81c_dc9e083e",
"range": {
"startLine": 63,
"startChar": 0,
"endLine": 64,
"endChar": 66
},
"revId": "4bae8265d8d62142de6b52e8a156f6ab3700e9c8",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -190,6 +304,30 @@
"revId": "4bae8265d8d62142de6b52e8a156f6ab3700e9c8",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "4bef191b_64533d96",
"filename": "magnum/common/policies/base.py",
"patchSetId": 21
},
"lineNbr": 67,
"author": {
"id": 12404
},
"writtenOn": "2023-05-31T18:16:46Z",
"side": 1,
"message": "Done",
"parentUuid": "b1adf78f_f721fd07",
"range": {
"startLine": 66,
"startChar": 0,
"endLine": 67,
"endChar": 52
},
"revId": "4bae8265d8d62142de6b52e8a156f6ab3700e9c8",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -213,6 +351,30 @@
"revId": "4bae8265d8d62142de6b52e8a156f6ab3700e9c8",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "66d91f25_545bfb06",
"filename": "magnum/common/policies/base.py",
"patchSetId": 21
},
"lineNbr": 161,
"author": {
"id": 12404
},
"writtenOn": "2023-05-31T18:16:46Z",
"side": 1,
"message": "let\u0027s enclose them all with ().",
"parentUuid": "e72a853b_69c755f7",
"range": {
"startLine": 161,
"startChar": 14,
"endLine": 161,
"endChar": 32
},
"revId": "4bae8265d8d62142de6b52e8a156f6ab3700e9c8",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -282,6 +444,30 @@
"revId": "4bae8265d8d62142de6b52e8a156f6ab3700e9c8",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "7612aa79_64ccd7c1",
"filename": "magnum/common/policies/cluster.py",
"patchSetId": 21
},
"lineNbr": 140,
"author": {
"id": 12404
},
"writtenOn": "2023-05-31T18:16:46Z",
"side": 1,
"message": "I propose adding enforce project member rule for both user or cluster user",
"parentUuid": "9d4ec096_4f77d9d2",
"range": {
"startLine": 140,
"startChar": 23,
"endLine": 140,
"endChar": 72
},
"revId": "4bae8265d8d62142de6b52e8a156f6ab3700e9c8",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -328,6 +514,54 @@
"revId": "4bae8265d8d62142de6b52e8a156f6ab3700e9c8",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "dede2b96_318a14f9",
"filename": "releasenotes/notes/enable-enforce-scope-and-new-defaults-7e6e503f74283071.yaml",
"patchSetId": 21
},
"lineNbr": 4,
"author": {
"id": 12404
},
"writtenOn": "2023-05-31T18:16:46Z",
"side": 1,
"message": "Done",
"parentUuid": "fc3a3889_f7074c1b",
"range": {
"startLine": 4,
"startChar": 70,
"endLine": 4,
"endChar": 75
},
"revId": "4bae8265d8d62142de6b52e8a156f6ab3700e9c8",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "bd357b5a_1ecafaa8",
"filename": "releasenotes/notes/enable-enforce-scope-and-new-defaults-7e6e503f74283071.yaml",
"patchSetId": 21
},
"lineNbr": 4,
"author": {
"id": 12404
},
"writtenOn": "2023-05-31T18:16:46Z",
"side": 1,
"message": "Done",
"parentUuid": "f3c77f64_591b367f",
"range": {
"startLine": 4,
"startChar": 23,
"endLine": 4,
"endChar": 52
},
"revId": "4bae8265d8d62142de6b52e8a156f6ab3700e9c8",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -351,6 +585,30 @@
"revId": "4bae8265d8d62142de6b52e8a156f6ab3700e9c8",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "ed9bcbef_7e2707d5",
"filename": "releasenotes/notes/enable-enforce-scope-and-new-defaults-7e6e503f74283071.yaml",
"patchSetId": 21
},
"lineNbr": 5,
"author": {
"id": 12404
},
"writtenOn": "2023-05-31T18:16:46Z",
"side": 1,
"message": "Done",
"parentUuid": "4d454f0d_25366ee8",
"range": {
"startLine": 5,
"startChar": 8,
"endLine": 5,
"endChar": 15
},
"revId": "4bae8265d8d62142de6b52e8a156f6ab3700e9c8",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -374,6 +632,30 @@
"revId": "4bae8265d8d62142de6b52e8a156f6ab3700e9c8",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "0e5d15e3_279208df",
"filename": "releasenotes/notes/enable-enforce-scope-and-new-defaults-7e6e503f74283071.yaml",
"patchSetId": 21
},
"lineNbr": 6,
"author": {
"id": 12404
},
"writtenOn": "2023-05-31T18:16:46Z",
"side": 1,
"message": "Done",
"parentUuid": "b41309ac_b7ab10bc",
"range": {
"startLine": 6,
"startChar": 24,
"endLine": 6,
"endChar": 36
},
"revId": "4bae8265d8d62142de6b52e8a156f6ab3700e9c8",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -396,6 +678,30 @@
},
"revId": "4bae8265d8d62142de6b52e8a156f6ab3700e9c8",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "8f4852e6_27c46b05",
"filename": "releasenotes/notes/enable-enforce-scope-and-new-defaults-7e6e503f74283071.yaml",
"patchSetId": 21
},
"lineNbr": 9,
"author": {
"id": 12404
},
"writtenOn": "2023-05-31T18:16:46Z",
"side": 1,
"message": "Done",
"parentUuid": "ae74b128_86e23200",
"range": {
"startLine": 9,
"startChar": 68,
"endLine": 9,
"endChar": 73
},
"revId": "4bae8265d8d62142de6b52e8a156f6ab3700e9c8",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}