Update patch set 1

Patch Set 1: (5 comments) Patch-set: 1
2023-05-25 08:44:14 +00:00 · 2023-05-25 08:44:14 +00:00 · 79c1b729f6
parent 7d604afdcf
commit 79c1b729f6
1 changed files with 89 additions and 0 deletions
--- a/89
+++ b/89
@ -0,0 +1,89 @@
+{
+  "comments": [
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "14df7531_063cd3ae",
+        "filename": "magnum/drivers/cluster_api/driver.py",
+        "patchSetId": 1
+      },
+      "lineNbr": 86,
+      "author": {
+        "id": 782
+      },
+      "writtenOn": "2023-05-25T08:44:14Z",
+      "side": 1,
+      "message": "let’s move this into the base patch?",
+      "revId": "c82bd80382b4db4da01a41b2a6a618fa1f691ada",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
+    },
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "65e6ce70_2309a681",
+        "filename": "magnum/drivers/cluster_api/driver.py",
+        "patchSetId": 1
+      },
+      "lineNbr": 416,
+      "author": {
+        "id": 782
+      },
+      "writtenOn": "2023-05-25T08:44:14Z",
+      "side": 1,
+      "message": "I would rather we make template a required arg to keep it simple an explicit?",
+      "revId": "c82bd80382b4db4da01a41b2a6a618fa1f691ada",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
+    },
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "6c3f41fc_16900086",
+        "filename": "magnum/drivers/cluster_api/driver.py",
+        "patchSetId": 1
+      },
+      "lineNbr": 430,
+      "author": {
+        "id": 782
+      },
+      "writtenOn": "2023-05-25T08:44:14Z",
+      "side": 1,
+      "message": "as above, make it required I think",
+      "revId": "c82bd80382b4db4da01a41b2a6a618fa1f691ada",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
+    },
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "d0b9158e_ad956135",
+        "filename": "magnum/drivers/cluster_api/driver.py",
+        "patchSetId": 1
+      },
+      "lineNbr": 738,
+      "author": {
+        "id": 782
+      },
+      "writtenOn": "2023-05-25T08:44:14Z",
+      "side": 1,
+      "message": "this seems very important! clearly should happen before we update the template id",
+      "revId": "c82bd80382b4db4da01a41b2a6a618fa1f691ada",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
+    },
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "4cfdb553_a2bb2f0e",
+        "filename": "magnum/drivers/cluster_api/driver.py",
+        "patchSetId": 1
+      },
+      "lineNbr": 748,
+      "author": {
+        "id": 782
+      },
+      "writtenOn": "2023-05-25T08:44:14Z",
+      "side": 1,
+      "message": "why not do a save here, then a refresh() we should be able to just use cluster_template everywhere then?\n\n… actually let’s update the state I guess, I know it duplicates the conductor, but that seems worth it?",
+      "revId": "c82bd80382b4db4da01a41b2a6a618fa1f691ada",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
+    }
+  ]
+}