From cbdf9454beba631b455ed04b56db7a6c22138d68 Mon Sep 17 00:00:00 2001 From: zhufl Date: Tue, 20 Sep 2016 11:59:08 +0800 Subject: [PATCH] Remove unnecessary setUp and tearDown setUp and tearDown will be automatically called around each testcase, so this is to remove setUp and tearDown that doing nothing additional than super to keep code clean. Change-Id: I3331d753da43c90f73082e6514a96b9fb9b67181 --- magnum/tests/unit/api/controllers/v1/test_certificate.py | 3 --- magnum/tests/unit/api/controllers/v1/test_magnum_service.py | 3 --- magnum/tests/unit/common/x509/test_validator.py | 6 ------ 3 files changed, 12 deletions(-) diff --git a/magnum/tests/unit/api/controllers/v1/test_certificate.py b/magnum/tests/unit/api/controllers/v1/test_certificate.py index 42065f89d9..c69c699c51 100644 --- a/magnum/tests/unit/api/controllers/v1/test_certificate.py +++ b/magnum/tests/unit/api/controllers/v1/test_certificate.py @@ -185,9 +185,6 @@ class TestPost(api_base.FunctionalTest): class TestCertPolicyEnforcement(api_base.FunctionalTest): - def setUp(self): - super(TestCertPolicyEnforcement, self).setUp() - def _common_policy_check(self, rule, func, *arg, **kwarg): self.policy.set_rules({rule: "project_id:non_fake"}) response = func(*arg, **kwarg) diff --git a/magnum/tests/unit/api/controllers/v1/test_magnum_service.py b/magnum/tests/unit/api/controllers/v1/test_magnum_service.py index b949962019..d6ca6843ec 100644 --- a/magnum/tests/unit/api/controllers/v1/test_magnum_service.py +++ b/magnum/tests/unit/api/controllers/v1/test_magnum_service.py @@ -44,9 +44,6 @@ class db_rec(object): class TestMagnumServiceController(api_base.FunctionalTest): - def setUp(self): - super(TestMagnumServiceController, self).setUp() - def test_empty(self): response = self.get_json('/mservices') self.assertEqual([], response['mservices']) diff --git a/magnum/tests/unit/common/x509/test_validator.py b/magnum/tests/unit/common/x509/test_validator.py index fc54fc8c1b..9661890459 100644 --- a/magnum/tests/unit/common/x509/test_validator.py +++ b/magnum/tests/unit/common/x509/test_validator.py @@ -19,12 +19,6 @@ from magnum.common.x509 import validator as v class TestValidators(unittest.TestCase): - def setUp(self): - super(TestValidators, self).setUp() - - def tearDown(self): - super(TestValidators, self).tearDown() - def _build_key_usage(self, critical=False): # Digital Signature and Key Encipherment are enabled key_usage = c_x509.KeyUsage(