openstack
/
magnum
Code Issues Proposed changes

Fix naming of variables/classes in tests 

The names of some of the variables had too much copy-paste, and they
were named k8s even in the mesos and swarm tests. The mesos test was
also named AtomicMesos* even though it was testing the UbuntuMesos
template definition class.

This is super trivial, but staring at these tests made me get irked by
them a little too much.

Change-Id: I863c080a8606992a66d7b517b63982da4caf9798
Closes-Bug: #1496568
This commit is contained in:
Ryan Rossiter 2015-09-16 20:36:22 +00:00
parent 4381c685b3
commit a2a19a9f75
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
magnum/tests/unit/conductor/test_template_definition.py
View File

@ -296,16 +296,16 @@ class AtomicSwarmTemplateDefinitionTestCase(base.TestCase):
self.assertEqual(mock_bay.discovery_url, actual_url)
def test_swarm_get_heat_param(self):
k8s_def = tdef.AtomicSwarmTemplateDefinition()
swarm_def = tdef.AtomicSwarmTemplateDefinition()
heat_param = k8s_def.get_heat_param(bay_attr='node_count')
heat_param = swarm_def.get_heat_param(bay_attr='node_count')
self.assertEqual(heat_param, 'number_of_nodes')
class AtomicMesosTemplateDefinitionTestCase(base.TestCase):
class UbuntuMesosTemplateDefinitionTestCase(base.TestCase):
def test_mesos_get_heat_param(self):
k8s_def = tdef.UbuntuMesosTemplateDefinition()
mesos_def = tdef.UbuntuMesosTemplateDefinition()
heat_param = k8s_def.get_heat_param(bay_attr='node_count')
heat_param = mesos_def.get_heat_param(bay_attr='node_count')
self.assertEqual(heat_param, 'number_of_slaves')