openstack/magnum
Code Issues Proposed changes

Remove default override for RBAC config options

Browse Source 
RBAC config options enforce_scope and enforce_new_defaults
were disabled by default in oslo.policy and Magnum had to override
the default value to enable those by default. Now oslo.policy
(4.4.0 onwards[1]) changed the default values[2] and enabled
by default for all the services. OpenStack service does not need
to override the default anymore.

NOTE: There is no change in behaviour here, oslo.policy provides the
same configuration that Magnum has overridden till now.

[1] https://review.opendev.org/c/openstack/releases/+/925032
[2] https://review.opendev.org/c/openstack/oslo.policy/+/924283

Depends-On: https://review.opendev.org/c/openstack/requirements/+/925464
Change-Id: Ifed33f4c5a687e299b64344661a8d51a843457a3
This commit is contained in:
Ghanshyam Mann 2024-08-09 11:59:07 -07:00
parent 8d09169a8a
commit a5db89bd88
2 changed files with 4 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
magnum/common/policy.py
View File

@ -33,14 +33,12 @@ _ENFORCER = None
CONF = cfg.CONF
# TODO(ricolin): Remove overriding the default value of config options
# 'policy_file', 'enforce_scope', and 'enforce_new_defaults' once
# oslo_policy change their default value to what is overridden here.
# 'policy_file' once oslo_policy change its default value to what
# is overridden here.
DEFAULT_POLICY_FILE = 'policy.yaml'
opts.set_defaults(
CONF,
DEFAULT_POLICY_FILE,
enforce_scope=True,
enforce_new_defaults=True
DEFAULT_POLICY_FILE
)

2
requirements.txt
View File

@ -30,7 +30,7 @@ oslo.i18n>=5.0.0 # Apache-2.0
oslo.log>=4.8.0 # Apache-2.0
oslo.messaging>=14.1.0 # Apache-2.0
oslo.middleware>=4.1.0 # Apache-2.0
oslo.policy>=3.11.0 # Apache-2.0
oslo.policy>=4.4.0 # Apache-2.0
oslo.reports>=2.1.0 # Apache-2.0
oslo.serialization>=3.2.0 # Apache-2.0
oslo.service>=2.2.0 # Apache-2.0