{ "comments": [ { "key": { "uuid": "3a961159_d7a22bad", "filename": "magnum/conductor/handlers/docker.py", "patchSetId": 1 }, "lineNbr": 27, "author": { "id": 668 }, "writtenOn": "2014-12-19T05:28:18Z", "side": 1, "message": "Consider having no default here. It does not make sense to run docker containers on the same host as the API service, so this particular default is not ideal.", "revId": "79e1fc01147dd3f68f1521964b5875ba401e92c9", "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543", "unresolved": false }, { "key": { "uuid": "3a961159_d7906b45", "filename": "magnum/conductor/handlers/docker.py", "patchSetId": 1 }, "lineNbr": 82, "author": { "id": 668 }, "writtenOn": "2014-12-19T05:28:18Z", "side": 1, "message": "Consider adding a bay_uuid argument here.", "revId": "79e1fc01147dd3f68f1521964b5875ba401e92c9", "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543", "unresolved": false }, { "key": { "uuid": "3a961159_f78e472d", "filename": "magnum/conductor/handlers/docker.py", "patchSetId": 1 }, "lineNbr": 88, "author": { "id": 668 }, "writtenOn": "2014-12-19T05:28:18Z", "side": 1, "message": "We should explicitly return \"Not Implemented\" to the client until we have an implementation for this, and the other methods that are awaiting implementation.", "revId": "79e1fc01147dd3f68f1521964b5875ba401e92c9", "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543", "unresolved": false }, { "key": { "uuid": "3a961159_97494e62", "filename": "magnum/conductor/handlers/docker.py", "patchSetId": 1 }, "lineNbr": 88, "author": { "id": 7494 }, "writtenOn": "2014-12-22T14:40:53Z", "side": 1, "message": "I see that most methods are returning None", "parentUuid": "3a961159_f78e472d", "revId": "79e1fc01147dd3f68f1521964b5875ba401e92c9", "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543", "unresolved": false } ] }