openstack
/
manila-specs
Code Issues Proposed changes

Update patch set 5 

Patch Set 5: Code-Review+1

(5 comments)

Patch-set: 5
Reviewer: Gerrit User 29632 <29632@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=+1, 8caa6f6c08beecccebd30e151100574bf9074fdf
Attention: {"person_ident":"Gerrit User 29632 \u003c29632@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_29632\u003e replied on the change"}
This commit is contained in:
Gerrit User 29632 2024-01-09 14:06:54 +00:00 committed by Gerrit Code Review
parent 092b9ca80d
commit 1128d9d5d1
1 changed files with 103 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

103
eb620542b3e75b689fbefd1d86fdb6505e38827c
View File

@ -1,5 +1,91 @@
{
"comments": [
{
"unresolved": false,
"key": {
"uuid": "2a22b768_4b218942",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 5
},
"lineNbr": 0,
"author": {
"id": 29632
},
"writtenOn": "2024-01-09T14:06:54Z",
"side": 1,
"message": "Kiran, thank you for the spec... Added some minor comments inline, but lgtm overall",
"revId": "eb620542b3e75b689fbefd1d86fdb6505e38827c",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "41b61de4_a176c015",
"filename": "specs/caracal/deferred_deletion.rst",
"patchSetId": 5
},
"lineNbr": 40,
"author": {
"id": 29632
},
"writtenOn": "2024-01-09T14:06:54Z",
"side": 1,
"message": "share, snapshot and their corresponding gigabytes quota.",
"range": {
"startLine": 39,
"startChar": 56,
"endLine": 40,
"endChar": 18
},
"revId": "eb620542b3e75b689fbefd1d86fdb6505e38827c",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "8706c307_8e5f35be",
"filename": "specs/caracal/deferred_deletion.rst",
"patchSetId": 5
},
"lineNbr": 53,
"author": {
"id": 29632
},
"writtenOn": "2024-01-09T14:06:54Z",
"side": 1,
"message": "shares",
"range": {
"startLine": 53,
"startChar": 2,
"endLine": 53,
"endChar": 7
},
"revId": "eb620542b3e75b689fbefd1d86fdb6505e38827c",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "7db60b7e_41cc7765",
"filename": "specs/caracal/deferred_deletion.rst",
"patchSetId": 5
},
"lineNbr": 53,
"author": {
"id": 29632
},
"writtenOn": "2024-01-09T14:06:54Z",
"side": 1,
"message": "manner, and if FALSE...",
"range": {
"startLine": 53,
"startChar": 41,
"endLine": 53,
"endChar": 52
},
"revId": "eb620542b3e75b689fbefd1d86fdb6505e38827c",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -46,6 +132,23 @@
},
"revId": "eb620542b3e75b689fbefd1d86fdb6505e38827c",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "4fa67f65_489bb312",
"filename": "specs/caracal/deferred_deletion.rst",
"patchSetId": 5
},
"lineNbr": 72,
"author": {
"id": 29632
},
"writtenOn": "2024-01-09T14:06:54Z",
"side": 1,
"message": "I believe the soft delete periodic task also should be modified in case of the default being the deferred deletion, right? I mean, it should set the status to deleting_in_driver and so on...",
"revId": "eb620542b3e75b689fbefd1d86fdb6505e38827c",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}